Bug 91164

Summary: Move m_type and m_hasNameCache from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, dglazkov, gustavo, kling, koivisto, philn, sam, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89919    
Attachments:
Description Flags
Patch
none
Removed the bits from the future andersca: review+, gyuyoung.kim: commit-queue-

Ryosuke Niwa
Reported 2012-07-12 16:39:17 PDT
Move m_collectionType and m_isNameCacheValid from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
Attachments
Patch (9.64 KB, patch)
2012-07-12 16:44 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed the bits from the future (9.45 KB, patch)
2012-07-12 16:47 PDT, Ryosuke Niwa 		andersca: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-07-12 16:44:16 PDT
Created attachment 152095 [details] Patch
Ryosuke Niwa
Comment 2 2012-07-12 16:46:05 PDT
Comment on attachment 152095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152095&action=review > Source/WebCore/html/HTMLCollection.cpp:73 > + case InvalidCollectionType: > + break; Oops, this shouldn't be here. I'm getting ahead of myself.
Ryosuke Niwa
Comment 3 2012-07-12 16:47:12 PDT
Created attachment 152097 [details] Removed the bits from the future
Gyuyoung Kim
Comment 4 2012-07-12 16:52:16 PDT
Comment on attachment 152097 [details] Removed the bits from the future Attachment 152097 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13230005
Ryosuke Niwa
Comment 5 2012-07-12 16:58:05 PDT
Oh oops, I did need InvalidCollectionType in DynamicNodeListCacheBase. Will add back & make sure it builds before landing it.
Early Warning System Bot
Comment 6 2012-07-12 17:02:20 PDT
Comment on attachment 152097 [details] Removed the bits from the future Attachment 152097 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13221423
Build Bot
Comment 7 2012-07-12 17:03:32 PDT
Comment on attachment 152097 [details] Removed the bits from the future Attachment 152097 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13221422
Build Bot
Comment 8 2012-07-12 17:04:29 PDT
Comment on attachment 152097 [details] Removed the bits from the future Attachment 152097 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13203909
Early Warning System Bot
Comment 9 2012-07-12 17:09:59 PDT
Comment on attachment 152097 [details] Removed the bits from the future Attachment 152097 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13209932
WebKit Review Bot
Comment 10 2012-07-12 17:12:31 PDT
Comment on attachment 152097 [details] Removed the bits from the future Attachment 152097 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13202879
Ryosuke Niwa
Comment 11 2012-07-12 17:20:50 PDT
Committed r122531: <http://trac.webkit.org/changeset/122531>
Ryosuke Niwa
Comment 12 2012-07-12 17:35:13 PDT
Apparently gcc doesn't catch all warnings :( I've landed a build fix in r122533.
Note You need to log in before you can comment on or make changes to this bug.