Bug 90608

Summary: [CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
Product: WebKit Reporter: Andrei Onea <andreionea3000>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87640    
Attachments:
Description Flags
Patch
none
Patch for landing none

Attachments
Patch (7.89 KB, patch)
2012-07-05 08:07 PDT, Andrei Onea 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.35 KB, patch)
2012-07-06 05:51 PDT, Andrei Onea 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Onea
Comment 1 2012-07-05 08:07:22 PDT
Created attachment 150940 [details] Patch
Andreas Kling
Comment 2 2012-07-06 05:20:54 PDT
Comment on attachment 150940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150940&action=review r=me with tiny tweaks: > LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html:18 > + description("Test for 90608: [CSSRegions]Implement NamedFlow::firsEmptyRegionIndex attribute."); Typo, firsEmptyRegionIndex. > Source/WebCore/dom/WebKitNamedFlow.cpp:66 > + int index; This variable should be scoped to the for loop below.
Andrei Onea
Comment 3 2012-07-06 05:51:22 PDT
Created attachment 151068 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-07-09 01:08:56 PDT
Comment on attachment 151068 [details] Patch for landing Clearing flags on attachment: 151068 Committed r122096: <http://trac.webkit.org/changeset/122096>
WebKit Review Bot
Comment 5 2012-07-09 01:09:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.