Bug 89416

Summary: [Chromium] Adjust the displayed elements of the new Chrome media controls
Product: WebKit Reporter: Silvia Pfeiffer <silviapf>
Component: MediaAssignee: Silvia Pfeiffer <silviapf>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, dglazkov, eric.carlson, feature-media-reviews, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84672    
Attachments:
Description Flags
get layout tests
none
Archive of layout-test-results from ec2-cr-linux-04
none
need new layout tests
none
Archive of layout-test-results from ec2-cr-linux-04
none
patch for review none

Silvia Pfeiffer
Reported 2012-06-18 20:25:45 PDT
Design for the new Chrome video controls requires removal of the volume slider if there is no sound or no source in the video/audio file.
Attachments
get layout tests (2.59 KB, patch)
2012-06-21 07:44 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-04 (1.07 MB, application/zip)
2012-06-21 08:45 PDT, WebKit Review Bot 		no flags
Details
need new layout tests (215.61 KB, patch)
2012-06-22 03:56 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-04 (986.91 KB, application/zip)
2012-06-22 07:06 PDT, WebKit Review Bot 		no flags
Details
patch for review (213.62 KB, patch)
2012-06-22 07:49 PDT, Silvia Pfeiffer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Silvia Pfeiffer
Comment 1 2012-06-21 07:06:36 PDT
Merge in patch from https://bugs.webkit.org/show_bug.cgi?id=89508 - these are all similar small changes to the video controls.
Silvia Pfeiffer
Comment 2 2012-06-21 07:44:35 PDT
Created attachment 148799 [details] get layout tests
Silvia Pfeiffer
Comment 3 2012-06-21 07:46:04 PDT
*** Bug 89508 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 4 2012-06-21 08:45:47 PDT
Comment on attachment 148799 [details] get layout tests Attachment 148799 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13029144 New failing tests: fullscreen/full-screen-stacking-context.html media/video-no-audio.html media/audio-repaint.html media/audio-controls-rendering.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/controls-layout-direction.html
WebKit Review Bot
Comment 5 2012-06-21 08:45:52 PDT
Created attachment 148812 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Silvia Pfeiffer
Comment 6 2012-06-22 03:56:37 PDT
Created attachment 148991 [details] need new layout tests
WebKit Review Bot
Comment 7 2012-06-22 07:06:52 PDT
Comment on attachment 148991 [details] need new layout tests Attachment 148991 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13037367 New failing tests: fullscreen/full-screen-stacking-context.html media/video-no-audio.html media/audio-repaint.html media/audio-controls-rendering.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/controls-layout-direction.html
WebKit Review Bot
Comment 8 2012-06-22 07:06:57 PDT
Created attachment 149021 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Silvia Pfeiffer
Comment 9 2012-06-22 07:49:27 PDT
Created attachment 149026 [details] patch for review
WebKit Review Bot
Comment 10 2012-06-22 11:25:26 PDT
Comment on attachment 149026 [details] patch for review Clearing flags on attachment: 149026 Committed r121043: <http://trac.webkit.org/changeset/121043>
WebKit Review Bot
Comment 11 2012-06-22 11:25:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.