Bug 87166

Summary: [chromium] LayerChromium should recognise existing layer active animations when the layer is added.
Product: WebKit Reporter: W. James MacLean <wjmaclean>
Component: New BugsAssignee: W. James MacLean <wjmaclean>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, dglazkov, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84487    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

W. James MacLean
Reported 2012-05-22 14:19:32 PDT
[chromium] LayerChromium should recognise existing layer active animations when the layer is added.
Attachments
Patch (6.83 KB, patch)
2012-05-22 14:22 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Patch (7.06 KB, patch)
2012-05-23 06:17 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.10 KB, patch)
2012-05-25 07:13 PDT, W. James MacLean 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
W. James MacLean
Comment 1 2012-05-22 14:22:40 PDT
Created attachment 143360 [details] Patch
WebKit Review Bot
Comment 2 2012-05-22 15:06:21 PDT
Comment on attachment 143360 [details] Patch Attachment 143360 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12760176
W. James MacLean
Comment 3 2012-05-23 06:17:36 PDT
Created attachment 143555 [details] Patch
W. James MacLean
Comment 4 2012-05-23 06:18:35 PDT
(In reply to comment #3) > Created an attachment (id=143555) [details] > Patch Replaces include file I inadvertently removed while "cleaning up" before submitting the first patch.
Adrienne Walker
Comment 5 2012-05-24 13:39:37 PDT
Comment on attachment 143555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143555&action=review R=me. > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:209 > + // Virtual for testing. The comment should go before the declaration. Although, I'm not convinced you actually need such a comment.
W. James MacLean
Comment 6 2012-05-25 07:13:49 PDT
Created attachment 144063 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-05-25 07:47:56 PDT
Comment on attachment 144063 [details] Patch for landing Clearing flags on attachment: 144063 Committed r118525: <http://trac.webkit.org/changeset/118525>
WebKit Review Bot
Comment 8 2012-05-25 07:48:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.