Bug 86864

Summary: [EFL] EFL's DRT needs to print information about received Web Intents
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gbillock, gyuyoung.kim, lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 85364    
Bug Blocks: 86868    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2012-05-18 09:58:20 PDT
EFL's DRT needs to print information about received Web Intents. This is needed by the following test cases: webintents/web-intents-obj-constructor.html webintents/web-intents-failure.html webintents/web-intents-invoke-port.html webintents/web-intents-invoke.html webintents/web-intents-reload.html = TEXT webintents/web-intents-reply.html = TEXT The output looks like: Received Web Intent: action=action1 type=text/plain Received Web Intent: action=action1 type=text/plain+explicit Explicit intent service: http://explicit.com/ Received Web Intent: action=action1 type=text/plain+extras Extras[a] = b Received Web Intent: action=action1 type=text/plain+port Have 1 ports
Attachments
Patch (12.47 KB, patch)
2012-05-22 01:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.42 KB, patch)
2012-05-22 05:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.39 KB, patch)
2012-05-22 06:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-05-22 01:43:25 PDT
Created attachment 143229 [details] Patch
WebKit Review Bot
Comment 2 2012-05-22 01:45:59 PDT
Attachment 143229 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 LayoutTests/platform/efl/test_expectations.txt:119: fast/events/show-modal-dialog-onblur-onfocus.html is also in a Skipped file. [test/expectations] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2012-05-22 01:49:51 PDT
Style issue is unrelated to this patch and will be addressed in Bug 87103.
Chris Dumez
Comment 4 2012-05-22 05:10:56 PDT
Created attachment 143281 [details] Patch Reupload the patch to get a green style bubble.
Chris Dumez
Comment 5 2012-05-22 06:16:37 PDT
Created attachment 143291 [details] Patch Fix a few style nits reported by Rakuco on IRC.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-05-22 06:20:12 PDT
Comment on attachment 143291 [details] Patch Looks fine, thanks.
Adam Barth
Comment 7 2012-05-22 10:11:54 PDT
Comment on attachment 143291 [details] Patch All the manual memory management looks really fragile. I don't know enough about EFL to know whether it's correct.
Chris Dumez
Comment 8 2012-05-22 10:18:32 PDT
abarth: There is unfortunately no reviewer with deep knowledge of EFL. Rakuco says the EFL part looks good to him and he is our reference. I don't see how I can avoid manual memory management here: I need to use the EFL types and C style.
Adam Barth
Comment 9 2012-05-22 10:20:50 PDT
Comment on attachment 143291 [details] Patch Ok. The intents-related parts look fine. If the EFL-related bits are fine, then we should be good to go.
WebKit Review Bot
Comment 10 2012-05-22 10:42:18 PDT
Comment on attachment 143291 [details] Patch Clearing flags on attachment: 143291 Committed r118000: <http://trac.webkit.org/changeset/118000>
WebKit Review Bot
Comment 11 2012-05-22 10:42:23 PDT
All reviewed patches have been landed. Closing bug.
Thiago Marcos P. Santos
Comment 12 2012-05-22 11:21:32 PDT
The following tests are failing after this change: webintents/web-intents-api.html = TEXT webintents/web-intents-invoke.html = TEXT webintents/web-intents-reload.html = TEXT Br, Your gardener in duty.
Chris Dumez
Comment 13 2012-05-22 11:26:39 PDT
Thiago: Based on the output on the bot, it appears it does not have the WEB_INTENTS flags enabled still. However, my patch enables it by default on EFL port and it works just fine on my machine. I think a clean build might be needed on the bot? Is it possible?
Chris Dumez
Comment 14 2012-05-22 12:04:56 PDT
False alarm. Removing the CMake cache on the bot and building again fixed the issue. The web intents tests are now passing, as expected.
Greg Billock
Comment 15 2012-05-22 13:34:21 PDT
Awesome! :-) (In reply to comment #14) > False alarm. Removing the CMake cache on the bot and building again fixed the issue. The web intents tests are now passing, as expected.
Note You need to log in before you can comment on or make changes to this bug.