Bug 83897

Summary:

[EFL][DRT] Enable Regions support

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

WebKit EFL

Assignee:

Dominik Röttsches (drott) <d-r>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, gyuyoung.kim, gyuyoung.kim, kenneth, lucas.de.marchi, mihnea, peter, rakuco, ryuan.choi, s.choi, sw0524.lee, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

57309

Bug Blocks:

97457

Attachments:

Description	Flags
Patch	none
Patch	none
Patch v3, fixing style issue in TestExpectations.	none
Patch	none
Patch	none

Dominik Röttsches (drott)

Reported 2012-04-13 09:40:16 PDT

CSS Regions should be enabled in compilation to pass related tests.

Attachments
Patch (188.64 KB, patch) 2012-09-21 02:13 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch (1.05 MB, patch) 2012-09-21 02:27 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch v3, fixing style issue in TestExpectations. (1.05 MB, patch) 2012-09-21 02:35 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch (1.06 MB, patch) 2012-09-24 08:39 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch (1.06 MB, patch) 2012-09-24 10:46 PDT, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dominik Röttsches (drott)

Comment 1 2012-04-16 01:09:06 PDT

For now, moving to test_expectations until implementation is marked complete in master bug.

Dominik Röttsches (drott)

Comment 2 2012-09-21 02:13:43 PDT

Created attachment 165084 [details] Patch

Dominik Röttsches (drott)

Comment 3 2012-09-21 02:14:55 PDT

Gyuyoung, Ryuan, Chris - any objections to default enabling CSS Regions for EFL?

Dominik Röttsches (drott)

Comment 4 2012-09-21 02:15:52 PDT

Will update the patch with pixel results.

WebKit Review Bot

Comment 5 2012-09-21 02:20:15 PDT

Attachment 165084 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. WARNING: Using the chromium port without having the downstream skia_test_expectations.txt file checked out. Expectations related things might be wonky. LayoutTests/platform/efl/TestExpectations:169: A test marked Skip or WontFix must not have other expectations. [test/expectations] [5] Total errors found: 1 in 129 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dominik Röttsches (drott)

Comment 6 2012-09-21 02:27:48 PDT

Created attachment 165090 [details] Patch

Dominik Röttsches (drott)

Comment 7 2012-09-21 02:35:22 PDT

Created attachment 165093 [details] Patch v3, fixing style issue in TestExpectations.

Gyuyoung Kim

Comment 8 2012-09-24 02:18:06 PDT

BTW, can't we adjust this into WK2 as well ?

Gyuyoung Kim

Comment 9 2012-09-24 02:31:18 PDT

(In reply to comment #8) > BTW, can't we adjust this into WK2 as well ? I mean we need to verify whether this patch will not influence on EFL WK2 layout test before landing this. Don't you need to update LayoutTests/platform/efl-wk2/TestExpectations ?

Dominik Röttsches (drott)

Comment 10 2012-09-24 02:39:34 PDT

(In reply to comment #9) > (In reply to comment #8) > > BTW, can't we adjust this into WK2 as well ? > > I mean we need to verify whether this patch will not influence on EFL WK2 layout test before landing this. Don't you need to update LayoutTests/platform/efl-wk2/TestExpectations ? The main TestExpectations file is searched by both bots, the results for the LayoutTests should be identical in this case, I checked this locally for the "regions" folder, but I'll double check again.

Dominik Röttsches (drott)

Comment 11 2012-09-24 08:39:58 PDT

Created attachment 165390 [details] Patch

Dominik Röttsches (drott)

Comment 12 2012-09-24 08:41:43 PDT

(In reply to comment #9) > Don't you need to update LayoutTests/platform/efl-wk2/TestExpectations ? I had to put one test case on the wk2 TestExpectations file, see bug 97457. The rest works fine.

WebKit Review Bot

Comment 13 2012-09-24 09:40:20 PDT

Comment on attachment 165390 [details] Patch Rejecting attachment 165390 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: tform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt patching file LayoutTests/platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt patching file LayoutTests/platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt patching file LayoutTests/platform/efl/fast/regions/webkit-region-rule-expected.txt patching file ChangeLog Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13989720

Dominik Röttsches (drott)

Comment 14 2012-09-24 10:46:51 PDT

Created attachment 165409 [details] Patch

Dominik Röttsches (drott)

Comment 15 2012-09-24 10:51:40 PDT

Comment on attachment 165409 [details] Patch Trying again with rebased ChangeLog

WebKit Review Bot

Comment 16 2012-09-24 11:49:56 PDT

Comment on attachment 165409 [details] Patch Clearing flags on attachment: 165409 Committed r129395: <http://trac.webkit.org/changeset/129395>

WebKit Review Bot

Comment 17 2012-09-24 11:50:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.