Bug 81021

Summary: [CSSRegions]NamedFlow::getRegionsByContentNode should not return a live NodeList
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80900    
Attachments:
Description Flags
Patch none

Mihnea Ovidenie
Reported 2012-03-13 12:20:22 PDT
Making the NamedFlow::getRegionsByContentNode return a live NodeList of regions is difficult and error prone. It also prevents refactoring like in https://bugs.webkit.org/show_bug.cgi?id=80900. I am reverting the original patch for https://bugs.webkit.org/show_bug.cgi?id=77746.
Attachments
Patch (87.34 KB, patch)
2012-03-13 12:46 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2012-03-13 12:46:15 PDT
Created attachment 131696 [details] Patch
WebKit Review Bot
Comment 2 2012-03-13 16:43:26 PDT
Comment on attachment 131696 [details] Patch Clearing flags on attachment: 131696 Committed r110639: <http://trac.webkit.org/changeset/110639>
WebKit Review Bot
Comment 3 2012-03-13 16:43:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.