Bug 79622

Summary: [Forms] Make order of attribute/method in HTMLInputElement.idl as same as specification
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch 1 none

yosin
Reported 2012-02-26 21:39:06 PST
For ease of maintainability, attributes and methods declaration order should be as same as specification. See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html
Attachments
Patch 1 (6.93 KB, patch)
2012-02-27 17:36 PST, yosin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-02-27 17:36:57 PST
Created attachment 129148 [details] Patch 1
Adam Barth
Comment 2 2012-02-27 17:52:15 PST
Comment on attachment 129148 [details] Patch 1 Ok. We'll probably screw up the ordering again in the future though.
yosin
Comment 3 2012-02-27 17:56:55 PST
(In reply to comment #2) > (From update of attachment 129148 [details]) > Ok. We'll probably screw up the ordering again in the future though. Thanks for quick response. I wrote simple Perl script for re-ordering to reduce manual handling. Obsolete comments and Objective-C #ifdef prevent me to make my script fully automatically.
WebKit Review Bot
Comment 4 2012-02-27 20:17:46 PST
Comment on attachment 129148 [details] Patch 1 Clearing flags on attachment: 129148 Committed r109067: <http://trac.webkit.org/changeset/109067>
WebKit Review Bot
Comment 5 2012-02-27 20:17:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.