Bug 78786

Summary:

[CSS Regions] Move regions tests from fast/repaint into fast/regions

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Mihnea Ovidenie <mihnea>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, donggwan.kim, gyuyoung.kim, mibalan, rakuco, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

63344

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Mihnea Ovidenie

Reported 2012-02-16 01:38:20 PST

There are 4 regions tests in fast/repaint. I intend to move them into fast/regions along with the other css regions tests.

Attachments
Patch (645.08 KB, patch) 2013-12-17 06:18 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (649.16 KB, patch) 2013-12-17 08:18 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mihai Balan

Comment 1 2013-05-23 04:18:52 PDT

They are better suited for the fast/repaint folder.

Mihnea Ovidenie

Comment 2 2013-12-17 05:42:26 PST

At this moment, there are more than 4 repaint tests for regions. Therefore i created a repaint folder under fast/regions and moved all the regions repaint tests there.

Mihnea Ovidenie

Comment 3 2013-12-17 06:18:19 PST

Created attachment 219414 [details] Patch

WebKit Commit Bot

Comment 4 2013-12-17 06:20:46 PST

Attachment 219414 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt', u'LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed.html', u'LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt', u'LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute.html', u'LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static-expected.txt', u'LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static.html', u'LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed-expected.txt', u'LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed.html', u'LayoutTests/fast/regions/fixed-in-named-flow-scroll-expected.txt', u'LayoutTests/fast/regions/fixed-in-named-flow-scroll.html', u'LayoutTests/fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt', u'LayoutTests/fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html', u'LayoutTests/fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt', u'LayoutTests/fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html', u'LayoutTests/fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt', u'LayoutTests/fast/regions/repaint/element-inflow-fixed-from-outflow-static.html', u'LayoutTests/fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt', u'LayoutTests/fast/regions/repaint/element-outflow-static-from-inflow-fixed.html', u'LayoutTests/fast/regions/repaint/fixed-in-named-flow-scroll-expected.txt', u'LayoutTests/fast/regions/repaint/fixed-in-named-flow-scroll.html', u'LayoutTests/fast/regions/repaint/increasing-region-content-height-expected.txt', u'LayoutTests/fast/regions/repaint/increasing-region-content-height.html', u'LayoutTests/fast/regions/repaint/japanese-rl-selection-repaint-in-regions.html', u'LayoutTests/fast/regions/repaint/line-flow-with-floats-in-regions.html', u'LayoutTests/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions.html', u'LayoutTests/fast/regions/repaint/region-painting-composited-element-expected.html', u'LayoutTests/fast/regions/repaint/region-painting-composited-element.html', u'LayoutTests/fast/regions/repaint/region-painting-in-composited-view-expected.html', u'LayoutTests/fast/regions/repaint/region-painting-in-composited-view.html', u'LayoutTests/fast/regions/repaint/region-painting-invalidation.html', u'LayoutTests/fast/regions/repaint/region-painting-via-layout.html', u'LayoutTests/fast/regions/repaint/repaint-regions-overflow-expected.txt', u'LayoutTests/fast/regions/repaint/repaint-regions-overflow.html', u'LayoutTests/fast/repaint/increasing-region-content-height-expected.txt', u'LayoutTests/fast/repaint/increasing-region-content-height.html', u'LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html', u'LayoutTests/fast/repaint/line-flow-with-floats-in-regions.html', u'LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions.html', u'LayoutTests/fast/repaint/region-painting-composited-element-expected.html', u'LayoutTests/fast/repaint/region-painting-composited-element.html', u'LayoutTests/fast/repaint/region-painting-in-composited-view-expected.html', u'LayoutTests/fast/repaint/region-painting-in-composited-view.html', u'LayoutTests/fast/repaint/region-painting-invalidation.html', u'LayoutTests/fast/repaint/region-painting-via-layout.html', u'LayoutTests/fast/repaint/repaint-regions-overflow-expected.txt', u'LayoutTests/fast/repaint/repaint-regions-overflow.html', u'LayoutTests/platform/efl/TestExpectations', u'LayoutTests/platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/mac/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-invalidation-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-invalidation-expected.txt', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-via-layout-expected.png', u'LayoutTests/platform/mac/fast/regions/repaint/region-painting-via-layout-expected.txt', u'LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png', u'LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png', u'LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png', u'LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt', u'LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.png', u'LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.txt', u'LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.png', u'LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt', u'LayoutTests/platform/win/TestExpectations', u'LayoutTests/platform/wincairo/TestExpectations', '--commit-queue']" exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file lines = self._read_lines(file_path) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines contents = file.read() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read return self.reader.read(size) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read newchars, decodedbytes = self.decode(data, self.errors) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte If any of these errors are false positives, please file a bug against check-webkit-style.

Dirk Schulze

Comment 5 2013-12-17 07:27:15 PST

Comment on attachment 219414 [details] Patch rs=me

Mihnea Ovidenie

Comment 6 2013-12-17 08:18:14 PST

Created attachment 219421 [details] Patch for landing

WebKit Commit Bot

Comment 7 2013-12-17 08:54:55 PST

Comment on attachment 219421 [details] Patch for landing Clearing flags on attachment: 219421 Committed r160708: <http://trac.webkit.org/changeset/160708>

WebKit Commit Bot

Comment 8 2013-12-17 08:54:58 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.