Bug 78771

Summary: Introduce HTMLInsertionPoint which will be a common base class of HTMLShadowElement and HTMLContentElement
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78596, 78778    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-02-15 18:55:35 PST
Since HTMLShadowElement and HTMLContentElement have similar functionality, we can share a lot of code for them. So it's reasonable to introduce a common base class, HTMLInsertionPoint.
Attachments
Patch (21.51 KB, patch)
2012-02-16 17:31 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (20.73 KB, patch)
2012-02-16 18:09 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (21.29 KB, patch)
2012-02-17 00:04 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (19.12 KB, patch)
2012-02-19 20:38 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-02-16 17:31:32 PST
Created attachment 127481 [details] Patch
Shinya Kawanaka
Comment 2 2012-02-16 18:09:29 PST
Created attachment 127489 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2012-02-16 20:10:03 PST
If it's a base class, perhaps it should be just InsertionPoint? HTML prefix is reserved for actual HTML elements.
Shinya Kawanaka
Comment 4 2012-02-16 22:19:56 PST
(In reply to comment #3) > If it's a base class, perhaps it should be just InsertionPoint? HTML prefix is reserved for actual HTML elements. OK. I'll change it so.
Shinya Kawanaka
Comment 5 2012-02-17 00:04:40 PST
Created attachment 127540 [details] Patch
Hayato Ito
Comment 6 2012-02-19 20:16:37 PST
Comment on attachment 127540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127540&action=review > Source/WebCore/html/shadow/InsertionPoint.h:48 > +#endif // ShadowElement_h Nit: Should be InsertionPoint_h
Shinya Kawanaka
Comment 7 2012-02-19 20:38:07 PST
(In reply to comment #6) > (From update of attachment 127540 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127540&action=review > > > Source/WebCore/html/shadow/InsertionPoint.h:48 > > +#endif // ShadowElement_h > > Nit: Should be InsertionPoint_h Thanks!
Shinya Kawanaka
Comment 8 2012-02-19 20:38:59 PST
Created attachment 127754 [details] Patch
WebKit Review Bot
Comment 9 2012-02-19 22:00:53 PST
Comment on attachment 127754 [details] Patch Clearing flags on attachment: 127754 Committed r108207: <http://trac.webkit.org/changeset/108207>
WebKit Review Bot
Comment 10 2012-02-19 22:00:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.