Bug 77909

Summary: Floated flexboxes render as regular RenderBlocks
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Layout and RenderingAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, hyatt, macpherson, menard, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://plexode.com/eval3/#ht=%3Cdiv%20style%3D%22border%3A1px%20solid%20blue%3Bdisplay%3A-webkit-flexbox%3Bfloat%3Aleft%22%3E%0A%20%20%20%20%3Cdiv%20style%3D%22background-color%3Apink%22%3Efoo%3C%2Fdiv%3E%0A%20%20%20%20%3Cdiv%20style%3D%22background-color%3Ared%22%3Ebarbaz%3C%2Fdiv%3E%0A%3C%2Fdiv%3E&ohh=1&ohj=1&jt=&ojh=1&ojj=1&ms=100&oth=0&otj=0&cex=1
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch eric: review+

Ojan Vafai
Reported 2012-02-06 16:00:18 PST
I expect layoutBlock never gets called for floats.
Attachments
Patch (6.66 KB, patch)
2012-02-07 16:38 PST, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (6.95 KB, patch)
2012-02-07 18:59 PST, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-02-07 16:38:52 PST
Created attachment 125953 [details] Patch
Ojan Vafai
Comment 2 2012-02-07 16:42:45 PST
Comment on attachment 125953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125953&action=review > LayoutTests/css3/flexbox/floated-flexbox-expected.txt:2 > +FAIL: > +Expected 130 for width, but got 110. This fails because of not implementing computePreferredLogicalWidth as per https://bugs.webkit.org/show_bug.cgi?id=76867. This patch fixes the expected height to be 30 instead of 50 since the flex-items no longer wrap now that we properly treat the parent as a flexbox.
WebKit Review Bot
Comment 3 2012-02-07 17:29:23 PST
Comment on attachment 125953 [details] Patch Attachment 125953 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11460165 New failing tests: fast/lists/001-vertical.html fast/block/float/016.html fast/lists/001.html fast/lists/positioned-count-crash.html
Darin Adler
Comment 4 2012-02-07 17:51:04 PST
Comment on attachment 125953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125953&action=review > Source/WebCore/css/CSSStyleSelector.cpp:1730 > +static void adjustDisplay(RenderStyle* style, Element *e, bool strictParsing) Element* element, not Element *e
Ojan Vafai
Comment 5 2012-02-07 18:59:01 PST
Created attachment 125984 [details] Patch
Ojan Vafai
Comment 6 2012-02-07 18:59:43 PST
Restructured after discussion with Eric.
Eric Seidel (no email)
Comment 7 2012-02-08 11:46:50 PST
Comment on attachment 125984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125984&action=review > Source/WebCore/css/CSSStyleSelector.cpp:1771 > + case NONE: // FIXME: Should NONE really map to BLOCK here? I'm not sure thsi FIXME makes sense anymore, but the code seems fine.
Ojan Vafai
Comment 8 2012-02-08 11:58:50 PST
Committed r107112: <http://trac.webkit.org/changeset/107112>
Note You need to log in before you can comment on or make changes to this bug.