Bug 77198

Summary: <feImage> DOM mutation problems
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77205    
Attachments:
Description Flags
Patch
none
Patch v2 koivisto: review+

Nikolas Zimmermann
Reported 2012-01-27 02:45:29 PST
<feImage> doesn't behave properly when its added/removed from the document. Dynamic changes of the target ID is not noticed, nor does it ever rebuild if it referenced an not-existing non-external resource before.
Attachments
Patch (28.23 KB, patch)
2012-01-27 03:01 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (29.45 KB, patch)
2012-01-27 04:11 PST, Nikolas Zimmermann 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2012-01-27 03:01:41 PST
Created attachment 124282 [details] Patch
WebKit Review Bot
Comment 2 2012-01-27 03:49:36 PST
Comment on attachment 124282 [details] Patch Attachment 124282 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11191702 New failing tests: svg/filters/feImage-target-remove-from-document.svg svg/filters/feImage-target-add-to-document.svg svg/filters/feImage-target-reappend-to-document.svg svg/filters/feImage-target-changes-id.svg svg/filters/feImage-target-id-change.svg
Nikolas Zimmermann
Comment 3 2012-01-27 04:11:43 PST
Created attachment 124287 [details] Patch v2
Antti Koivisto
Comment 4 2012-01-27 04:52:25 PST
Comment on attachment 124287 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=124287&action=review r=me > Source/WebCore/svg/SVGFEImageElement.cpp:75 > if (m_cachedImage) { > m_cachedImage->removeClient(this); > m_cachedImage = 0; > } Use early return since you are here?
Nikolas Zimmermann
Comment 5 2012-01-27 04:55:08 PST
(In reply to comment #4) > (From update of attachment 124287 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=124287&action=review > > r=me > > > Source/WebCore/svg/SVGFEImageElement.cpp:75 > > if (m_cachedImage) { > > m_cachedImage->removeClient(this); > > m_cachedImage = 0; > > } > > Use early return since you are here? Thanks for the quick review, a follow-up patch will add more content to this method, so I prefer to leave it as-is.
Nikolas Zimmermann
Comment 6 2012-01-27 04:56:43 PST
Committed r106110: <http://trac.webkit.org/changeset/106110>
Note You need to log in before you can comment on or make changes to this bug.