Bug 75463

Summary:

[EFL][WK2] Add InjectedBundleEfl.cpp

Product:

WebKit

Reporter:

YoungTaeck Song <youngtaeck.song>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, ryuan.choi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

Bug Blocks:

61838

Attachments:

Description	Flags
patch for InjectedBundleEfl	none
patch for InjectedBundleEfl	none
patch for InjectedBundleEfl	none
patch for InjectedBundleEfl	none

YoungTaeck Song

Reported 2012-01-03 00:42:44 PST

Add first version of InjectedBundleEfl.cpp including load() and placeholder for activateMacFontAscentHack().

Attachments
patch for InjectedBundleEfl (2.73 KB, patch) 2012-01-03 02:44 PST, YoungTaeck Song	no flags	Details Formatted Diff Diff
patch for InjectedBundleEfl (2.74 KB, patch) 2012-01-03 03:43 PST, YoungTaeck Song	no flags	Details Formatted Diff Diff
patch for InjectedBundleEfl (2.89 KB, patch) 2012-01-11 00:23 PST, YoungTaeck Song	no flags	Details Formatted Diff Diff
patch for InjectedBundleEfl (3.14 KB, patch) 2012-01-13 01:52 PST, YoungTaeck Song	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

YoungTaeck Song

Comment 1 2012-01-03 02:44:18 PST

Created attachment 120922 [details] patch for InjectedBundleEfl

WebKit Review Bot

Comment 2 2012-01-03 02:47:46 PST

Attachment 120922 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

YoungTaeck Song

Comment 3 2012-01-03 03:43:18 PST

Created attachment 120926 [details] patch for InjectedBundleEfl

Gyuyoung Kim

Comment 4 2012-01-03 16:39:30 PST

Comment on attachment 120926 [details] patch for InjectedBundleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:-44 > - notImplemented(); Why did you remove notImplemented() in here? I think it is better to keep it until this function is implemented.

YoungTaeck Song

Comment 5 2012-01-03 16:51:04 PST

(In reply to comment #4) > (From update of attachment 120926 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:-44 > > - notImplemented(); > > Why did you remove notImplemented() in here? I think it is better to keep it until this function is implemented. ===> notImplemented() was removed in all other ports. Please see InjectedBundleMac.cpp and so on.

Gyuyoung Kim

Comment 6 2012-01-10 23:22:51 PST

Comment on attachment 120926 [details] patch for InjectedBundleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:44 > + if (!initializeFunction) I think it is better to add debugging message when failing to get initializeFuncction like qt, gtk.

YoungTaeck Song

Comment 7 2012-01-11 00:23:52 PST

Created attachment 121989 [details] patch for InjectedBundleEfl add debugging messages

Andreas Kling

Comment 8 2012-01-12 00:47:08 PST

Comment on attachment 121989 [details] patch for InjectedBundleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=121989&action=review > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:42 > + m_platformBundle = eina_module_new(m_path.utf8().data()); > + if (!m_platformBundle || !eina_module_load(m_platformBundle)) { > + EINA_LOG_CRIT("Error loading the injected bundle: %s", m_path.utf8().data()); > + return false; If eina_module_new() is successful but eina_module_load() is not, don't you need to call eina_module_free() before returning?

YoungTaeck Song

Comment 9 2012-01-13 01:51:47 PST

(In reply to comment #8) > (From update of attachment 121989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121989&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:42 > > + m_platformBundle = eina_module_new(m_path.utf8().data()); > > + if (!m_platformBundle || !eina_module_load(m_platformBundle)) { > > + EINA_LOG_CRIT("Error loading the injected bundle: %s", m_path.utf8().data()); > > + return false; > > If eina_module_new() is successful but eina_module_load() is not, don't you need to call eina_module_free() before returning? Thank you for your kind review. I fixed it in the next patch.

YoungTaeck Song

Comment 10 2012-01-13 01:52:21 PST

Created attachment 122394 [details] patch for InjectedBundleEfl

Ryuan Choi

Comment 11 2012-02-26 22:07:30 PST

LGTM.

WebKit Review Bot

Comment 12 2012-02-26 23:48:05 PST

Comment on attachment 122394 [details] patch for InjectedBundleEfl Clearing flags on attachment: 122394 Committed r108961: <http://trac.webkit.org/changeset/108961>

WebKit Review Bot

Comment 13 2012-02-26 23:48:10 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.