Bug 74930

Summary: MediaStream API: Adding WebUserMediaClientMock to enable LayoutTesting
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: fishd, webkit.review.bot, wjia
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 74882    
Attachments:
Description Flags
Patch fishd: review-

Tommy Widenflycht
Reported 2011-12-20 07:26:59 PST
This is the first of 3 patches (2 WebKit and 1 chromium) to enable an initial LayoutTest. The second webkit patch is https://bugs.webkit.org/show_bug.cgi?id=74882, and the chromium patch is http://codereview.chromium.org/8887004.
Attachments
Patch (7.97 KB, patch)
2011-12-20 07:59 PST, Tommy Widenflycht 		fishd: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2011-12-20 07:59:41 PST
Created attachment 120027 [details] Patch
WebKit Review Bot
Comment 2 2011-12-20 08:02:00 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2011-12-22 09:12:09 PST
Comment on attachment 120027 [details] Patch This looks like test-only code that is implemented on top of the existing WebKit API. Why should this also be part of the WebKit API?
wjia
Comment 4 2011-12-27 16:49:35 PST
(In reply to comment #3) > (From update of attachment 120027 [details]) > This looks like test-only code that is implemented on top of the existing WebKit API. Why should this also be part of the WebKit API? This mocked class needs to access WebKit::WebMediaStreamDescriptor, WebKit::WebMediaStreamSource, etc, which are not accessible from Tools/DumpRenderTree/chromium. What's the best directory for WebUserMediaClientMock?
Darin Fisher (:fishd, Google)
Comment 5 2012-01-04 10:55:39 PST
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 120027 [details] [details]) > > This looks like test-only code that is implemented on top of the existing WebKit API. Why should this also be part of the WebKit API? > > This mocked class needs to access WebKit::WebMediaStreamDescriptor, WebKit::WebMediaStreamSource, etc, which are not accessible from Tools/DumpRenderTree/chromium. What's the best directory for WebUserMediaClientMock? Tools/DumpRenderTree/chromium is a consumer of the WebKit API. WebMediaStreamDescriptor and WebMediaStreamSource are part of the WebKit API. We don't have a lot of mocks in WebKit, but the few that we have are either in the tests/ folder, or part of the API because they expose WebCore mocks. I'm not sure that these latter mocks are really that good of an idea as I'm not sure why they should exist in a shipping browser. It seems to me that if the only consumer of this mock is DRT, that the code should just live alongside DRT.
wjia
Comment 6 2012-01-05 15:51:00 PST
patch in bug 74882 has move the WebUserMediaClientMock from Source/WebKit/chromium to Tools/DumpRenderTree/chromium. An embedder API (webkit_support::MediaStreamUtil) has been created in chromium patch http://codereview.chromium.org/8887004/. Therefore, all changes in WebKit has been consolidated in bug 74882. This bug can be closed if code review confirms the both chromium patch and patch in bug 74882 are ok.
wjia
Comment 7 2012-01-12 10:24:42 PST
The code in this patch has been merged into bug 74882 which has been fixed as r104764. Closing this one. *** This bug has been marked as a duplicate of bug 74882 ***
Note You need to log in before you can comment on or make changes to this bug.