Bug 72009

Summary: Remove virtual toPathData() method from all graphics elements
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 71780    
Bug Blocks:    
Attachments:
Description Flags
Patch
webkit.review.bot: commit-queue-
Patch v2 zherczeg: review+, webkit-ews: commit-queue-

Nikolas Zimmermann
Reported 2011-11-10 02:02:46 PST
In bug 71780, SVGLengthContext was introduced, to allow to resolve SVGLengths against arbitary viewports. SVGLength::value(), which needs a SVGLengthContext, is still used all over svg/ - that should be changed, as rendering/ should resolve these lengths, as HTML does it using Length & RenderStyles for CSS. As first step, move the #1 client of the SVGLength::value() methods - toPathData() out of svg/ into rendering/svg/SVGPathData as free-function, replacing the virtual toPathData() function from SVGStyledTransformableElement.
Attachments
Patch (32.41 KB, patch)
2011-11-10 02:16 PST, Nikolas Zimmermann 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (32.58 KB, patch)
2011-11-10 02:35 PST, Nikolas Zimmermann 		zherczeg: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-11-10 02:16:39 PST
Created attachment 114457 [details] Patch Inspired by Anttis&Andreas work, I also want to devirtualize something ;-) The actual goal is to move all length resolution into rendering/, instead of doing it in svg/ dom. This is a first step towards it.
WebKit Review Bot
Comment 2 2011-11-10 02:24:01 PST
Comment on attachment 114457 [details] Patch Attachment 114457 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10404265
Gyuyoung Kim
Comment 3 2011-11-10 02:30:08 PST
Comment on attachment 114457 [details] Patch Attachment 114457 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10354321
Nikolas Zimmermann
Comment 4 2011-11-10 02:35:19 PST
Created attachment 114459 [details] Patch v2 Fix cr/efl builds.
Early Warning System Bot
Comment 5 2011-11-10 02:46:25 PST
Comment on attachment 114459 [details] Patch v2 Attachment 114459 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10364017
Zoltan Herczeg
Comment 6 2011-11-10 03:11:46 PST
Comment on attachment 114459 [details] Patch v2 r=me with the following comments View in context: https://bugs.webkit.org/attachment.cgi?id=114459&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-1360 > - 50B42158146976960087E604 /* WebKitCSSShaderValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 50B42157146976960087E604 /* WebKitCSSShaderValue.h */; }; This shouldn't be removed. And fix Qt build.
WebKit Review Bot
Comment 7 2011-11-10 03:12:55 PST
Comment on attachment 114459 [details] Patch v2 Attachment 114459 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10411015
Nikolas Zimmermann
Comment 8 2011-11-10 03:44:23 PST
Landed cr build fix in r99836. Turns out I had to add SVGPathData.* in two places in the gypi file, very confusing.
Note You need to log in before you can comment on or make changes to this bug.