Bug 67969

Summary: Implement a HashChangeEvent constructor for V8
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67824    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2011-09-12 16:24:16 PDT
We have been working on implementing constructors of Events. HashChangeEvent has a constructor in JSC (https://bugs.webkit.org/show_bug.cgi?id=67924), but do not have it in V8.
Attachments
Patch (4.48 KB, patch)
2011-09-12 16:30 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-12 16:30:58 PDT
Created attachment 107106 [details] Patch
Nate Chapin
Comment 2 2011-09-13 16:36:25 PDT
Comment on attachment 107106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review > Source/WebCore/dom/HashChangeEvent.idl:26 > - CustomConstructFunction > + CustomConstructFunction, > + V8CustomConstructor It looks like there's substantial overlap between these two attributes. Is there any chance we could merge them?
Hajime Morrita
Comment 3 2011-09-13 17:00:58 PDT
Comment on attachment 107106 [details] Patch Haraken should respond Chapin's comment.
WebKit Review Bot
Comment 4 2011-09-13 18:04:34 PDT
Comment on attachment 107106 [details] Patch Clearing flags on attachment: 107106 Committed r95063: <http://trac.webkit.org/changeset/95063>
WebKit Review Bot
Comment 5 2011-09-13 18:04:39 PDT
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 6 2011-09-14 01:32:11 PDT
(In reply to comment #2) > (From update of attachment 107106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107106&action=review > > > Source/WebCore/dom/HashChangeEvent.idl:26 > > - CustomConstructFunction > > + CustomConstructFunction, > > + V8CustomConstructor > > It looks like there's substantial overlap between these two attributes. Is there any chance we could merge them? Sure! I will do it sometime soon.
Note You need to log in before you can comment on or make changes to this bug.