Bug 67414

Summary: Generate an XSLTProcessor constructor of V8 using the IDL 'Constructor' extended attribute
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dominicc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65839    
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2011-09-01 09:42:50 PDT
Currently, the XSLTProcessor constructor is written manually as a custom constructor. We should replace this with automatically generated code by the IDL 'Constructor' extended attribute.
Attachments
Patch (2.17 KB, patch)
2011-09-01 13:49 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (2.17 KB, patch)
2011-09-01 14:11 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-09-01 13:49:20 PDT
Created attachment 106022 [details] Patch
Kentaro Hara
Comment 2 2011-09-01 14:11:37 PDT
Created attachment 106026 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2011-09-01 14:30:13 PDT
Comment on attachment 106026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106026&action=review > Source/WebCore/xml/XSLTProcessor.idl:38 > CustomConstructFunction, Is this still necessary?
Kentaro Hara
Comment 4 2011-09-01 14:34:50 PDT
> > Source/WebCore/xml/XSLTProcessor.idl:38 > > CustomConstructFunction, > > Is this still necessary? Yes, it is still used in JSC. We will remove it when we support the 'Constructor' extended attribute in JSC.
WebKit Review Bot
Comment 5 2011-09-01 15:15:28 PDT
Comment on attachment 106026 [details] Patch Clearing flags on attachment: 106026 Committed r94350: <http://trac.webkit.org/changeset/94350>
WebKit Review Bot
Comment 6 2011-09-01 15:15:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.