Bug 6692
| Summary: | Certain non-undoable DOM operations can cause unexpected behavior or crashes later on Undo/Redo | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Justin Garcia <justin.garcia> |
| Component: | HTML Editing | Assignee: | Justin Garcia <justin.garcia> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | alexander.steitz, darin, enrica, ian, rniwa |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| Bug Depends on: | |||
| Bug Blocks: | 6627 | ||
Justin Garcia
The Undo stack gets hosed by TinyMCE's custom Undo. In "custom-undo" mode, TinyMCE use execCommand(Undo, ...) to implement Undo, it uses setInnerHTML, and our Undo stack isn't bulletproof against arbitrary DOM operations.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Justin Garcia
I meant to say "In 'custom-undo' mode, TinyMCE DOESN'T use execCommand(Undo, ...)..." in my comments above.
Ryosuke Niwa
I haven't seen crashes caused by this bug as long as I've been working on the editing. So I'd assume we've worked out all the kinks in undo/redo by now.
Please file more specific bugs and/or re-open this bug if you find specific crashes or unexpected behavior caused by this bug.