Bug 64833

Summary: Bring Int/Float graphics classes closer to parity
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2011-07-19 15:50:35 PDT
There are still some inconsistencies between IntPoint/FloatPoint, RoundedRect using floats, etc.
Attachments
Patch (23.28 KB, patch)
2011-07-19 16:09 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-07-19 15:58:08 PDT
Why don't we use template classes for Point/Rect/Size?
Levi Weintraub
Comment 2 2011-07-19 16:04:29 PDT
For one, there are various overloads and implicit conversions that make sense to do from int->float but not the other way around. Functions like isZero would also need specialization for floats.
Levi Weintraub
Comment 3 2011-07-19 16:09:36 PDT
Created attachment 101405 [details] Patch
James Robinson
Comment 4 2011-07-20 13:51:26 PDT
Comment on attachment 101405 [details] Patch I think this is good. It might be worth investigating sharing more code between IntPoint/FloatPoint, but at a glance it doesn't seem trivial. We could handle a lot of cases with partial specialization.
Levi Weintraub
Comment 5 2011-07-20 14:56:30 PDT
Comment on attachment 101405 [details] Patch Thanks for the review!
WebKit Review Bot
Comment 6 2011-07-20 16:18:41 PDT
Comment on attachment 101405 [details] Patch Clearing flags on attachment: 101405 Committed r91417: <http://trac.webkit.org/changeset/91417>
WebKit Review Bot
Comment 7 2011-07-20 16:18:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.