Bug 64279

This patch reverted the changes landed in r90601 & r90602, which should not have changed any jsc test results. * Did you see these tests start working between r90600 to r90602? * Can you repro these tests working under r90672 and failing on r90673?

It seems jsc tests now pass, but there are many layout tests crash intermittently: - ietestcenter/Javascript/15.2.3.11-1.html - fast/css/first-letter-anonymous-block-crash.html - fast/dom/attribute-namespaces.xhtml - fast/dynamic/insertAdjacentText.html - svg/custom/svg-parse-overflow-5.html - fast/css/dashboard-regions-attr-crash.html

Layout tests still crash intermittently on the Qt-Mac buildbots: - trunk bot: http://build.webkit.sed.hu/builders/Qt%20SnowLeopard%20Intel%20Release - 2.2 branch bot: http://build.webkit.sed.hu/builders/QtWebKit2.2-branch%20SnowLeopard%20Intel%20Release It seems it is a serious JavaScriptCore bug, but I can't help to fix it, because I don't have QtWebKit build environment on Mac and I'm not a JSC expert. But it should block 2.2 release, because it would be a shame if we would release QtWebKit 2.2 with this annoying JSC bug.

cc-ing Alexis the Mac-QtWebKit hacker

(In reply to comment #3) > Layout tests still crash intermittently on the Qt-Mac buildbots: > > - trunk bot: http://build.webkit.sed.hu/builders/Qt%20SnowLeopard%20Intel%20Release > - 2.2 branch bot: http://build.webkit.sed.hu/builders/QtWebKit2.2-branch%20SnowLeopard%20Intel%20Release > > It seems it is a serious JavaScriptCore bug, but I can't help to fix it, because I don't have QtWebKit build environment on Mac and I'm not a JSC expert. But it should block 2.2 release, because it would be a shame if we would release QtWebKit 2.2 with this annoying JSC bug. r90673 is not present in QtWebKit-2.2 and the mac-buildbot for 2.2 has been unstable for a while... Is there a correlation between the failures from there and this bug? Below are the crashes from the 5 builds: #163: fast/css/button-height.html fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html svg/dom/SVGAnimatedBoolean.html #164: sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T2.html svg/dom/svglist-exception-on-out-bounds-error.html #165: fast/gradients/css3-gradient-parsing.html fast/js/exception-thrown-from-eval-inside-closure.html sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T7.html #166: fast/frames/flattening/iframe-flattening-nested.html fast/profiler/start-and-stop-profiler-multiple-times.html #167: fast/dom/array-special-accessors-should-ignore-items.html

I don't know what caused these crashes. Maybe r90673 is absolutely innocent. I noticed crashes from this revision. But debugging without crash log and without QtWebKit build on Mac is absolutely impossible. Somebody who has QtWebKit build on a Mac should debug this bug. I don't think if the bot is unstable, but there is a serious JSC bug in QtWebKit on Mac. But I can't confirm it without a local build.

Since we're not sure if this bug indeed affects qtwebkit-2.2, I'm removing it from the blockers list. If we get confirmation, we'll add it back. BTW, the build passed just now and the 2.2 mac bot is now green.

(In reply to comment #7) > Since we're not sure if this bug indeed affects qtwebkit-2.2, I'm removing it from the blockers list. If we get confirmation, we'll add it back. > > BTW, the build passed just now and the 2.2 mac bot is now green. And who will it check? I think removing this bug from blocker list and/or releasing QtWebKit 2.2 without checking what cause random crashes on Mac is absolutely non-sense ... PS. I'm sure that the Mac bot will be red for the next build.

(In reply to comment #8) > (In reply to comment #7) > > Since we're not sure if this bug indeed affects qtwebkit-2.2, I'm removing it from the blockers list. If we get confirmation, we'll add it back. > > > > BTW, the build passed just now and the 2.2 mac bot is now green. > > And who will it check? I think removing this bug from blocker list and/or releasing QtWebKit 2.2 without checking what cause random crashes on Mac is absolutely non-sense ... We're about to release a qtwebkit-2.2 RC and this problem (or non-problem) has always been there. If that's indeed a problem, we'll catch it somewhere down the road and add the fix to the release branch. But keeping a bug blocking the release without anyone working on a fix and without even knowing if it's indeed a problem won't benefit anybody. We'll never release 2.2 if we want it to be perfect. > > PS. I'm sure that the Mac bot will be red for the next build. I'm sure too, and it has been like this for ages. I'm not saying it's a good thing, I'm just saying that I don't know what's causing it and I don't see resources being allocated to fix it.

js1_5/Regress/regress-152646.js and js1_5/Regress/regress-192414.js started to fail again after http://trac.webkit.org/changeset/95016

Change the name of the bug, because nobody can confirm if it is a regression or not, because nobody maintains QtWebKit on Mac now. :(

Nobody runs layout tests on Qt Mac, nobody knows if it is valid bug or not, so we can simple close it as wontfix.