Bug 63221

Summary: sheriffbot can no longer restart
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2011-06-22 19:27:23 PDT
sheriffbot can no longer restart Requested by abarth on #webkit.
Attachments
Patch (5.08 KB, patch)
2011-06-23 11:56 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-06-22 19:28:01 PDT
Eric broke this when catching Exception. We use exceptions to terminate!
Eric Seidel (no email)
Comment 2 2011-06-22 19:51:37 PDT
Since when do good designs use exceptions for normal control flow? :p. Besides, the unit tests pass. :)
Adam Barth
Comment 3 2011-06-22 20:18:05 PDT
You're welcome to change the design when you fix the bug. :)
Eric Seidel (no email)
Comment 4 2011-06-23 11:56:57 PDT
Created attachment 98376 [details] Patch
Adam Barth
Comment 5 2011-06-23 13:58:57 PDT
Comment on attachment 98376 [details] Patch Nice. I didn't know that about SystemExit.
WebKit Review Bot
Comment 6 2011-06-23 14:42:10 PDT
The commit-queue encountered the following flaky tests while processing attachment 98376 [details]: fast/filesystem/file-writer-truncate-extend.html bug 63292 (author: ericu@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 7 2011-06-23 14:43:50 PDT
Comment on attachment 98376 [details] Patch Clearing flags on attachment: 98376 Committed r89618: <http://trac.webkit.org/changeset/89618>
WebKit Review Bot
Comment 8 2011-06-23 14:43:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.