Bug 62868

Summary: Avoid extra work in RenderStyle::visitedDependentColor
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: CSSAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://code.google.com/p/chromium/issues/attachmentText?id=73106&aid=541403547953126335&name=chromium-bugreport.txt
Attachments:
Description Flags
Proposed fix: refactor the logic of RenderStyle::visitedDependentColor none

Julien Chaffraix
Reported 2011-06-17 09:20:26 PDT
The URL attached URL is a table of 22k rows. Each row has an anchor (a link to the source line for easy copyiing and pasting). When profiling the page, I found out that RenderStyle::visitedColorDependentColor is a hot function accounting for 10% to 15% of the total time. We are calling it too often but this bug is about optimizing the function itself. Patch forthcoming.
Attachments
Proposed fix: refactor the logic of RenderStyle::visitedDependentColor (5.46 KB, patch)
2011-06-17 09:41 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-06-17 09:41:09 PDT
Created attachment 97608 [details] Proposed fix: refactor the logic of RenderStyle::visitedDependentColor
WebKit Review Bot
Comment 2 2011-06-17 10:35:28 PDT
The commit-queue encountered the following flaky tests while processing attachment 97608 [details]: http/tests/local/link-stylesheet-load-order.html bug 62878 (author: koivisto@iki.fi) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 3 2011-06-17 10:36:56 PDT
Comment on attachment 97608 [details] Proposed fix: refactor the logic of RenderStyle::visitedDependentColor Clearing flags on attachment: 97608 Committed r89142: <http://trac.webkit.org/changeset/89142>
WebKit Review Bot
Comment 4 2011-06-17 10:37:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.