Bug 62078

Summary: Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
Product: WebKit Reporter: Chris Rogers <crogers>
Component: Web AudioAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kbr: review+

Chris Rogers
Reported 2011-06-03 17:53:54 PDT
Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
Attachments
Patch (36.10 KB, patch)
2011-06-03 18:06 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-06-03 18:06:39 PDT
Created attachment 96002 [details] Patch
Chris Rogers
Comment 2 2011-06-03 18:11:01 PDT
See filter cookbook reference: http://www.musicdsp.org/files/Audio-EQ-Cookbook.txt For newly implemented filter types.
Kenneth Russell
Comment 3 2011-06-08 12:00:19 PDT
Comment on attachment 96002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96002&action=review I'm not qualified to review the math for the coefficients but have a couple of minor comments. Also, when are you going to delete the LowPass2FilterNode and HighPass2FilterNode, or at least implement them in terms of the Biquad2FilterNode? If they're deprecated then their construction should probably log a warning message to the console that they will be removed soon. There are not enough users of the Web Audio API at this point to warrant keeping them around permanently. > Source/WebCore/platform/audio/Biquad.cpp:230 > + double a0Inverse = 1.0 / a0; All of the .0's in this file seem unnecessary and so should be removed per WebKit style. > Source/WebCore/platform/audio/Biquad.cpp:250 > + // FIXME: optimize the common terms Why not at least define aPlusOne and aMinusOne now rather than adding this FIXME? > Source/WebCore/platform/audio/Biquad.cpp:272 > + // FIXME: optimize the common terms Same question about common terms.
Chris Rogers
Comment 4 2011-06-08 13:29:23 PDT
Committed r88380: <http://trac.webkit.org/changeset/88380>
Chris Rogers
Comment 5 2011-06-08 13:30:52 PDT
Comment on attachment 96002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96002&action=review I also added console warnings for deprecated APIs >> Source/WebCore/platform/audio/Biquad.cpp:230 >> + double a0Inverse = 1.0 / a0; > > All of the .0's in this file seem unnecessary and so should be removed per WebKit style. FIXED >> Source/WebCore/platform/audio/Biquad.cpp:250 >> + // FIXME: optimize the common terms > > Why not at least define aPlusOne and aMinusOne now rather than adding this FIXME? FIXED >> Source/WebCore/platform/audio/Biquad.cpp:272 >> + // FIXME: optimize the common terms > > Same question about common terms. FIXED
Note You need to log in before you can comment on or make changes to this bug.