Bug 59923

Summary: EWS should report the list of unexpected failures
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 59272    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-05-02 02:50:52 PDT
EWS should report the list of unexpected failures
Attachments
Patch (4.58 KB, patch)
2011-05-02 02:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-05-02 02:53:50 PDT
Created attachment 91902 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-02 10:13:38 PDT
Comment on attachment 91902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447 > + task = self._run_through_task(commit_queue, expected_stderr, ScriptError) > + self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"]) Seems to support the case that this should be moved onto a custom Exception.
Adam Barth
Comment 3 2011-05-02 11:57:18 PDT
(In reply to comment #2) > (From update of attachment 91902 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review > > > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447 > > + task = self._run_through_task(commit_queue, expected_stderr, ScriptError) > > + self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"]) > > Seems to support the case that this should be moved onto a custom Exception. Actually, if we moved it onto a custom exception, the test would be even harder to write. :)
WebKit Commit Bot
Comment 4 2011-05-02 13:03:04 PDT
Comment on attachment 91902 [details] Patch Clearing flags on attachment: 91902 Committed r85509: <http://trac.webkit.org/changeset/85509>
WebKit Commit Bot
Comment 5 2011-05-02 13:03:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.