Bug 59811

Summary: Extract a function to obtain VisiblePosition from RenderText::positionForPoint
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, darin, eric, hyatt, jamesr, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 59435    
Attachments:
Description Flags
cleanup none

Ryosuke Niwa
Reported 2011-04-29 11:09:57 PDT
The part of RenderText::positionForPoint that returns visible positions when various conditions are met can be split into a separate function.
Attachments
cleanup (4.40 KB, patch)
2011-04-29 12:11 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-04-29 12:11:14 PDT
Created attachment 91716 [details] cleanup
Eric Seidel (no email)
Comment 2 2011-04-29 17:31:02 PDT
Comment on attachment 91716 [details] cleanup LGTM.
Ryosuke Niwa
Comment 3 2011-04-29 17:32:34 PDT
Thanks for the review, Eric.
WebKit Commit Bot
Comment 4 2011-04-29 18:12:28 PDT
The commit-queue encountered the following flaky tests while processing attachment 91716 [details]: http/tests/workers/shared-worker-importScripts.html bug 58634 (author: atwilson@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-04-29 18:13:39 PDT
Comment on attachment 91716 [details] cleanup Clearing flags on attachment: 91716 Committed r85377: <http://trac.webkit.org/changeset/85377>
WebKit Commit Bot
Comment 6 2011-04-29 18:13:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.