Bug 59586

Summary: [GTK][Qt] fast/events/keydown-1.html fails
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, cshu
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
fix patch none

Martin Robinson
Reported 2011-04-27 00:57:22 PDT
The period is not missing from the end of the sentence, as the test suggests. --- /tmp/layout-test-results/fast/events/keydown-1-expected.txt 2011-04-27 00:56:22.484711997 -0700 +++ /tmp/layout-test-results/fast/events/keydown-1-actual.txt 2011-04-27 00:56:22.484711997 -0700 @@ -3,4 +3,4 @@ keydown in subframe: [object KeyboardEvent] keydown in subframe: [object KeyboardEvent] -This sentence should not end with a period +This sentence should not end with a period.
Attachments
fix patch (2.53 KB, patch)
2011-05-02 13:39 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-04-27 10:15:39 PDT
FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though.
Martin Robinson
Comment 2 2011-04-27 10:20:12 PDT
(In reply to comment #1) > FWIW, the test was converted to text only in <trac.webkit.org/r84897>. This looks more like an actual bug in the port at a first glance though. Yes, even before the text conversion this test was incredibly flaky across different machines. The text conversion provides good impetus to finally squash this bug.
Chang Shu
Comment 3 2011-04-27 10:34:58 PDT
I believe so. The pixel result may falsely consider it's passing because one dot doesn't contribute much in the whole image. This test also fails on Qt but it was skipped. I suspect it's a key binding issue. Probably we should rewrite the test to use common key codes.
Chang Shu
Comment 4 2011-05-02 13:39:23 PDT
Created attachment 91970 [details] fix patch
Martin Robinson
Comment 5 2011-05-02 13:48:44 PDT
Comment on attachment 91970 [details] fix patch Thanks!
WebKit Commit Bot
Comment 6 2011-05-02 15:19:08 PDT
The commit-queue encountered the following flaky tests while processing attachment 91970 [details]: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-05-02 15:20:32 PDT
Comment on attachment 91970 [details] fix patch Clearing flags on attachment: 91970 Committed r85528: <http://trac.webkit.org/changeset/85528>
WebKit Commit Bot
Comment 8 2011-05-02 15:20:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.