Bug 58087
| Summary: | MediaControlFullscreenButton should just call HTMLMediaElement::enterFullScreen() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> |
| Component: | Media | Assignee: | Jer Noble <jer.noble> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | fred.wang |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | |||
| Bug Blocks: | 276855 | ||
Jer Noble
Now that enterFullscreen() does the right thing if the new full screen API is enabled, there's no need to special case MediaControlFullscreenButton.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Frédéric Wang Nélar
MediaControlFullscreenButton does not seem to exist anymore. MediaControllerInterface::enterFullscreen() is only overriden by MediaController and HTMLMedialElement: https://searchfox.org/wubkat/rev/8697bb2e6e78ade6d7e8915c0de15807552a2230/Source/WebCore/html/MediaControllerInterface.h#73
Closing this but feel free to reopen if this is still valid.