Bug 57020

Summary:

[Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes

Product:

WebKit

Reporter:

Yi Shen <max.hong.shen>

Component:

WebKit Qt

Assignee:

Yi Shen <max.hong.shen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, laszlo.gombos, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

Other

Bug Depends on:

Bug Blocks:

50925

Attachments:

Description	Flags
first try	menard: review-, menard: commit-queue-
remove maemo macro	none

Yi Shen

Reported 2011-03-24 08:49:23 PDT

On Symbian, QWebView::inputMethodHints() returns more information than it returns on Linux/Win/Mac. Will provide a patch soon.

Attachments
first try (4.93 KB, patch) 2011-03-24 08:53 PDT, Yi Shen	menard: review- menard: commit-queue-	Details Formatted Diff Diff
remove maemo macro (4.88 KB, patch) 2011-03-30 12:19 PDT, Yi Shen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yi Shen

Comment 1 2011-03-24 08:53:41 PDT

Created attachment 86780 [details] first try

Kenneth Rohde Christiansen

Comment 2 2011-03-24 11:44:24 PDT

Comment on attachment 86780 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 > +#ifdef Q_OS_SYMBIAN This also counts for other platforms like MAEMO etc. Please verify and fix as well

Yi Shen

Comment 3 2011-03-24 13:57:12 PDT

(In reply to comment #2) > (From update of attachment 86780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review > > > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 > > +#ifdef Q_OS_SYMBIAN > > This also counts for other platforms like MAEMO etc. Please verify and fix as well Hi Kenneth, I am agree with you that MAEMO may have the same issue, and I would suggest to create a separate bug to test/fix the issue. Again, thanks for the review :)

Alexis Menard (darktears)

Comment 4 2011-03-29 10:30:01 PDT

Comment on attachment 86780 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review >>> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 >>> +#ifdef Q_OS_SYMBIAN >> >> This also counts for other platforms like MAEMO etc. Please verify and fix as well > > Hi Kenneth, I am agree with you that MAEMO may have the same issue, and I would suggest to create a separate bug to test/fix the issue. Again, thanks for the review :) Can you test it? > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:319 > +#if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) || defined(Q_OS_SYMBIAN) Why here #if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) if your patch doesn't actually covers Maemo?

Yi Shen

Comment 5 2011-03-30 11:38:25 PDT

(In reply to comment #4) > (From update of attachment 86780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review > > >>> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 > >>> +#ifdef Q_OS_SYMBIAN > >> > >> This also counts for other platforms like MAEMO etc. Please verify and fix as well > > > > Hi Kenneth, I am agree with you that MAEMO may have the same issue, and I would suggest to create a separate bug to test/fix the issue. Again, thanks for the review :) > > Can you test it? Thanks for your input, Alexis. Unfortunately, I don't have a meego/maemo env at hand to test it. So I created a bug for the same issue on meego/maemo (https://bugs.webkit.org/show_bug.cgi?id=57485), and will look at it when I got a chance.(Or someone has meego env can make a quick patch for it) > > > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:319 > > +#if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) || defined(Q_OS_SYMBIAN) > > Why here #if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) if your patch doesn't actually covers Maemo? I am going to remove the Maemo tag from this patch

Yi Shen

Comment 6 2011-03-30 12:19:03 PDT

Created attachment 87595 [details] remove maemo macro

Alexis Menard (darktears)

Comment 7 2011-03-30 13:03:41 PDT

Comment on attachment 87595 [details] remove maemo macro LGTM

WebKit Commit Bot

Comment 8 2011-03-30 16:19:49 PDT

Comment on attachment 87595 [details] remove maemo macro Clearing flags on attachment: 87595 Committed r82517: <http://trac.webkit.org/changeset/82517>

WebKit Commit Bot

Comment 9 2011-03-30 16:19:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.