Bug 55782

Summary: [Qt] Need symbian version of cryptographicallyRandomValuesFromOS
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: JavaScriptCoreAssignee: Viatcheslav Ostapenko <ostap73>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Bug Depends on:    
Bug Blocks: 50251    
Attachments:
Description Flags
Symbian version of cryptographicallyRandomValuesFromOS
none
Fix style error
none
Fix changelog. none

Viatcheslav Ostapenko
Reported 2011-03-04 09:53:14 PST
Symbian doesn't have /dev/urandom and qtwebkit crashes because it cannot open this file.
Attachments
Symbian version of cryptographicallyRandomValuesFromOS (1.71 KB, patch)
2011-03-04 09:58 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
Fix style error (1.71 KB, patch)
2011-03-04 10:09 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
Fix changelog. (1.71 KB, patch)
2011-03-04 12:15 PST, Viatcheslav Ostapenko 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Viatcheslav Ostapenko
Comment 1 2011-03-04 09:58:49 PST
Created attachment 84768 [details] Symbian version of cryptographicallyRandomValuesFromOS
WebKit Review Bot
Comment 2 2011-03-04 10:00:43 PST
Attachment 84768 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OSRandomSource.cpp:59: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Viatcheslav Ostapenko
Comment 3 2011-03-04 10:09:57 PST
Created attachment 84774 [details] Fix style error
Viatcheslav Ostapenko
Comment 4 2011-03-04 12:15:54 PST
Created attachment 84789 [details] Fix changelog.
Laszlo Gombos
Comment 5 2011-03-04 12:24:26 PST
Comment on attachment 84789 [details] Fix changelog. Looks good to me. r+.
WebKit Commit Bot
Comment 6 2011-03-04 22:03:06 PST
Comment on attachment 84789 [details] Fix changelog. Clearing flags on attachment: 84789 Committed r80407: <http://trac.webkit.org/changeset/80407>
WebKit Commit Bot
Comment 7 2011-03-04 22:03:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.