Bug 54939

Summary: [Chromium] keycode is always 0 when using non-Latin keyboard layout.
Product: WebKit Reporter: James Su <suzhe>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: avi, commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.6   
URL: http://unixpapa.com/js/testkey.html
Attachments:
Description Flags
Patch to fix this issue.
dglazkov: review-, commit-queue: commit-queue-
Fix email address in ChangeLog files. none

James Su
Reported 2011-02-21 23:28:55 PST
What steps will reproduce the problem? 1. Open http://unixpapa.com/js/testkey.html 2. Switch to a non-Latin keyboard layout, eg. Russian, Arabic. 3. Press some keys. What is the expected output? What do you see instead? keyCode value of key events should not be zero, but they are always zero when using non-Latin keyboard layout. See: http://crbug.com/73119
Attachments
Patch to fix this issue. (18.36 KB, patch)
2011-02-21 23:48 PST, James Su 		dglazkov: review-
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Fix email address in ChangeLog files. (18.34 KB, patch)
2011-03-03 20:17 PST, James Su 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Su
Comment 1 2011-02-21 23:48:43 PST
Created attachment 83277 [details] Patch to fix this issue.
Dimitri Glazkov (Google)
Comment 2 2011-02-22 08:44:55 PST
Avi, can you take a look?
Avi Drissman
Comment 3 2011-02-22 09:10:03 PST
(In reply to comment #2) > Avi, can you take a look? I like this. The original code was stolen from KeyEventMac, which was seriously cleaned up afterwards. We should match KeyEventMac.
Eric Seidel (no email)
Comment 4 2011-02-24 03:09:29 PST
Comment on attachment 83277 [details] Patch to fix this issue. Yay! How do we test this?
James Su
Comment 5 2011-02-24 17:31:11 PST
(In reply to comment #4) > (From update of attachment 83277 [details]) > Yay! How do we test this? I'm wondering if we could extend DumpRenderTree's keyDown method to support generating key event with arbitrary content, so that we could write layout tests as normal.
James Su
Comment 6 2011-02-28 10:44:07 PST
Can anybody help commit?
James Su
Comment 7 2011-03-01 20:37:37 PST
ping?
WebKit Commit Bot
Comment 8 2011-03-03 12:33:00 PST
Comment on attachment 83277 [details] Patch to fix this issue. Rejecting attachment 83277 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/8085324
WebKit Commit Bot
Comment 9 2011-03-03 19:40:05 PST
Comment on attachment 83277 [details] Patch to fix this issue. Rejecting attachment 83277 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/8087415
James Su
Comment 10 2011-03-03 19:52:32 PST
Can anyone help me look into this problem? (In reply to comment #9) > (From update of attachment 83277 [details]) > Rejecting attachment 83277 [details] from commit-queue. > > Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-a..." exit_code: 1 > > Last 500 characters of output: > ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run > step(tool, options).run(state) > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run > if self._has_valid_reviewer(changelog_entry): > File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer > if changelog_entry.reviewer(): > AttributeError: 'NoneType' object has no attribute 'reviewer' > > Full output: http://queues.webkit.org/results/8087415
Dimitri Glazkov (Google)
Comment 11 2011-03-03 20:00:39 PST
Comment on attachment 83277 [details] Patch to fix this issue. The ChangeLog is malformed. Look at author's name. It should be in "Bob Foobar <bob@foobar.baz>" format.
James Su
Comment 12 2011-03-03 20:17:23 PST
Created attachment 84683 [details] Fix email address in ChangeLog files.
James Su
Comment 13 2011-03-03 20:18:19 PST
My fault. New patch uploaded, please have a look. (In reply to comment #11) > (From update of attachment 83277 [details]) > The ChangeLog is malformed. Look at author's name. It should be in "Bob Foobar <bob@foobar.baz>" format.
Dimitri Glazkov (Google)
Comment 14 2011-03-03 20:26:51 PST
Comment on attachment 84683 [details] Fix email address in ChangeLog files. all systems go.
WebKit Commit Bot
Comment 15 2011-03-04 01:02:56 PST
The commit-queue encountered the following flaky tests while processing attachment 84683 [details]: inspector/timeline/timeline-network-resource.html bug 55751 (authors: loislo@chromium.org, pfeldman@chromium.org, and yurys@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 16 2011-03-04 01:04:58 PST
Comment on attachment 84683 [details] Fix email address in ChangeLog files. Clearing flags on attachment: 84683 Committed r80336: <http://trac.webkit.org/changeset/80336>
WebKit Commit Bot
Comment 17 2011-03-04 01:05:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.