Bug 54106

Summary: frames/flattening/iframe-flattening-crash.html fails on GTK.
Product: WebKit Reporter: Yael <yael>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch.
mrobinson: review+
Patch. none

Yael
Reported 2011-02-09 07:40:07 PST
This test is constructed differently then other frame flattening tests. Seems that the frame flattening flag is turned on too late, so layout is not triggered and the test fails. I modified the test and would appreciate it if someone with WebKitGTK could test it and let me know if the new format works. A patch is coming.
Attachments
Patch. (3.61 KB, patch)
2011-02-09 07:49 PST, Yael 		mrobinson: review+
DetailsFormatted DiffDiff
Patch. (4.19 KB, patch)
2011-02-09 09:09 PST, Yael 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2011-02-09 07:49:52 PST
Created attachment 81814 [details] Patch. Modified the test to be more consistent with the other frame flattening tests. Martin, could you or someone with WebKitGTK please test if it fixes the WebKitGTK problem? thanks.
Martin Robinson
Comment 2 2011-02-09 08:48:22 PST
Comment on attachment 81814 [details] Patch. This test is passing now on GTK+. In your patch do you also think you could remove the file from the GTK+ skipped list. It's currently the last skipped test. Thanks for the fix!
Yael
Comment 3 2011-02-09 08:58:09 PST
(In reply to comment #2) > (From update of attachment 81814 [details]) > This test is passing now on GTK+. In your patch do you also think you could remove the file from the GTK+ skipped list. It's currently the last skipped test. Thanks for the fix! Thanks for testing. I will update the patch to remove the skipped test.
Yael
Comment 4 2011-02-09 09:09:07 PST
Created attachment 81820 [details] Patch.
WebKit Commit Bot
Comment 5 2011-02-09 11:06:34 PST
Comment on attachment 81820 [details] Patch. Clearing flags on attachment: 81820 Committed r78085: <http://trac.webkit.org/changeset/78085>
WebKit Commit Bot
Comment 6 2011-02-09 11:06:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.