Bug 53131

Thread 4 (Thread 0xb3959b70 (LWP 9295)): #0 0xb7883424 in __kernel_vsyscall () #1 0xb5881de6 in poll () from /lib/libc.so.6 #2 0xb5aa299b in g_poll (fds=0x9e252c8, nfds=3, timeout=-1) at /build/buildd/glib2.0-2.27.91/glib/gpoll.c:132 #3 0xb5a9232f in g_main_context_poll (context=0x9e248e8, block=-1247139472, dispatch=1, self=<value optimized out>) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:3404 #4 g_main_context_iterate (context=0x9e248e8, block=-1247139472, dispatch=1, self=<value optimized out>) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:3086 #5 0xb5a92aab in g_main_loop_run (loop=0x9e248d8) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:3299 #6 0xb5c35344 in gdbus_shared_thread_func (data=0x0) at /build/buildd/glib2.0-2.27.91/gio/gdbusprivate.c:276 #7 0xb5abb66f in g_thread_create_proxy (data=0x9e24978) at /build/buildd/glib2.0-2.27.91/glib/gthread.c:1897 #8 0xb5925e79 in start_thread () from /lib/libpthread.so.0 #9 0xb58904ee in clone () from /lib/libc.so.6 Thread 3 (Thread 0xafea2b70 (LWP 9297)): #0 0xb7883424 in __kernel_vsyscall () #1 0xb592a46c in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/libpthread.so.0 #2 0xb72d6a87 in WTF::TCMalloc_PageHeap::scavengerThread() () from /usr/lib/libwebkit-1.0.so.2 #3 0xb72d6acd in WTF::TCMalloc_PageHeap::runScavengerThread(void*) () from /usr/lib/libwebkit-1.0.so.2 #4 0xb5925e79 in start_thread () from /lib/libpthread.so.0 #5 0xb58904ee in clone () from /lib/libc.so.6 Thread 2 (Thread 0xaf581b70 (LWP 9298)): #0 0xb7883424 in __kernel_vsyscall () #1 0xb592a46c in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/libpthread.so.0 #2 0xb72e9734 in WTF::ThreadCondition::wait(WTF::Mutex&) () from /usr/lib/libwebkit-1.0.so.2 #3 0xb69ab332 in WebCore::IconDatabase::syncThreadMainLoop() () from /usr/lib/libwebkit-1.0.so.2 #4 0xb69acb4f in WebCore::IconDatabase::iconDatabaseSyncThread() () from /usr/lib/libwebkit-1.0.so.2 #5 0xb69acc9d in WebCore::IconDatabase::iconDatabaseSyncThreadStart(void*) () from /usr/lib/libwebkit-1.0.so.2 #6 0xb72e940f in WTF::threadEntryPoint(void*) () from /usr/lib/libwebkit-1.0.so.2 #7 0xb5925e79 in start_thread () from /lib/libpthread.so.0 #8 0xb58904ee in clone () from /lib/libc.so.6 Thread 1 (Thread 0xb3e7a860 (LWP 9294)): #0 0xb7883424 in __kernel_vsyscall () #1 0xb57eac41 in raise () from /lib/libc.so.6 #2 0xb57ee11e in abort () from /lib/libc.so.6 #3 0xb5821bd7 in ?? () from /lib/libc.so.6 #4 0xb582bfe1 in ?? () from /lib/libc.so.6 #5 0xb582d93b in ?? () from /lib/libc.so.6 #6 0xb5830acd in free () from /lib/libc.so.6 #7 0xb5a98e96 in g_free (mem=0x9f2c290) at /build/buildd/glib2.0-2.27.91/glib/gmem.c:263 #8 0xb647eeab in textForRenderer(WebCore::RenderObject*) () from /usr/lib/libwebkit-1.0.so.2 #9 0xb647f1ed in textForObject(WebCore::AccessibilityRenderObject*) () from /usr/lib/libwebkit-1.0.so.2 #10 0xb6480e8f in getPangoLayoutForAtk(_AtkText*) () from /usr/lib/libwebkit-1.0.so.2 #11 0xb6480f74 in webkit_accessible_text_get_text_at_offset(_AtkText*, int, AtkTextBoundary, int*, int*) () from /usr/lib/libwebkit-1.0.so.2 #12 0xb5495d0d in atk_text_get_text_at_offset (text=0xa33b8c8, offset=0, boundary_type=ATK_TEXT_BOUNDARY_LINE_START, start_offset=0xbff45b6c, end_offset=0xbff45b68) at atktext.c:421 #13 0xb3b5a05a in impl_getTextAtOffset (servant=0x9e28ad4, offset=0, type=Accessibility_TEXT_BOUNDARY_LINE_START, startOffset=0xbff45c60, endOffset=0xbff45c40, ev=0xbff45ee0) at text.c:128 #14 0xb3b4e61c in _ORBIT_skel_small_Accessibility_Text_getTextAtOffset (_o_servant=0x9e28ad4, _o_retval=0xbff45d00, _o_args=0xbff45ce0, _o_ctx=0xbff45d7c, _o_ev=0xbff45ee0, _impl_getTextAtOffset=0xb3b5a010 <impl_getTextAtOffset>) at Accessibility-common.c:744 #15 0xb57410c7 in ?? () from /usr/lib/libORBit-2.so.0 #16 0xb5747e25 in ORBit_OAObject_invoke () from /usr/lib/libORBit-2.so.0 #17 0xb57337f9 in ORBit_small_invoke_adaptor () from /usr/lib/libORBit-2.so.0 #18 0xb574319a in ?? () from /usr/lib/libORBit-2.so.0 #19 0xb5743887 in ?? () from /usr/lib/libORBit-2.so.0 #20 0xb5743a1d in ?? () from /usr/lib/libORBit-2.so.0 #21 0xb5747ce1 in ORBit_handle_request () from /usr/lib/libORBit-2.so.0 #22 0xb5730095 in giop_connection_handle_input () from /usr/lib/libORBit-2.so.0 #23 0xb574ec4a in ?? () from /usr/lib/libORBit-2.so.0 #24 0xb5751a96 in ?? () from /usr/lib/libORBit-2.so.0 #25 0xb5a91c28 in g_main_dispatch (context=0x9dcdf30) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:2440 #26 g_main_context_dispatch (context=0x9dcdf30) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:3013 #27 0xb5a923f0 in g_main_context_iterate (context=0x9dcdf30, block=-1247139472, dispatch=1, self=<value optimized out>) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:3091 #28 0xb5a92aab in g_main_loop_run (loop=0x9e2b9b8) at /build/buildd/glib2.0-2.27.91/glib/gmain.c:3299 #29 0xb5ffc329 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 #30 0x0806ec82 in main ()

Created attachment 80219 [details] Patch proposal Simple patch to fix this. It seems there was an error in how the length in bytes for a UTF8 substring was being calculated.

The change looks good to me. Is there any way to write a test for it?

(In reply to comment #3) > The change looks good to me. Is there any way to write a test for it? I didn't think it was needed as it was a minor change in a helper function, but I could write an unit test if you want, although I think it's perhaps a little overkill for such a small change... As you wish :-)

Created attachment 80239 [details] Patch proposal + unit tests Attaching new patch including a new unit test.

Comment on attachment 80239 [details] Patch proposal + unit tests Thanks for including the test.

Committed r76721: <http://trac.webkit.org/changeset/76721>