Bug 52184

Summary: Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: kbalazs, kling, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 52183    
Bug Blocks:    
Attachments:
Description Flags
Patch
sam: review+
patch with qt parts
none
Patch none

Anders Carlsson
Reported 2011-01-10 17:59:14 PST
Work towards having the WebPageProxy decide when to create the DrawingAreaProxy
Attachments
Patch (9.04 KB, patch)
2011-01-10 18:04 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
patch with qt parts (14.49 KB, patch)
2011-01-11 07:33 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (13.08 KB, patch)
2011-01-11 08:38 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-10 18:04:48 PST
Created attachment 78485 [details] Patch
WebKit Review Bot
Comment 2 2011-01-10 18:07:24 PST
Attachment 78485 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/AP..." exit_code: 1 WebKit2/UIProcess/API/mac/WKViewInternal.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2011-01-10 18:12:12 PST
Committed r75459: <http://trac.webkit.org/changeset/75459>
Csaba Osztrogonác
Comment 4 2011-01-10 19:56:10 PST
(In reply to comment #3) > Committed r75459: <http://trac.webkit.org/changeset/75459> It broke Qt build: ../../../WebKit2/UIProcess/API/qt/qwkpage_p.h:46: error: ‘DrawingAreaProxy’ was not declared in this scope ../../../WebKit2/UIProcess/API/qt/qwkpage_p.h:46: error: template argument 1 is invalid ../../../WebKit2/UIProcess/API/qt/qwkpage_p.h:46: error: conflicting return type specified for ‘virtual int QWKPagePrivate::createDrawingAreaProxy()’ ../../../WebKit2/UIProcess/PageClient.h:53: error: overriding ‘virtual WTF::PassOwnPtr<WebKit::DrawingAreaProxy> WebKit::PageClient::createDrawingAreaProxy()’ Could you guys fix the build or roll it out?
Csaba Osztrogonác
Comment 5 2011-01-10 20:30:11 PST
(In reply to comment #3) > Committed r75459: <http://trac.webkit.org/changeset/75459> Rolled-out: http://trac.webkit.org/changeset/75473
Csaba Osztrogonác
Comment 6 2011-01-11 03:30:57 PST
Comment on attachment 78485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78485&action=review > WebKit2/UIProcess/API/qt/qwkpage_p.h:46 > + virtual PassOwnPtr<DrawingAreaProxy> createDrawingAreaProxy(); WebKit::DrawingAreaProxy instead of DrawingAreaProxy will make Qt build happier.
Csaba Osztrogonác
Comment 7 2011-01-11 03:41:39 PST
Comment on attachment 78485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78485&action=review > WebKit2/UIProcess/API/qt/qwkpage.cpp:126 > +PassOwnPtr<DrawingAreaProxy> QWKPagePrivate::createDrawingAreaProxy() > +{ > + // FIXME: Implement. See https://bugs.webkit.org/show_bug.cgi?id=52183. > +} After fix in Comment #6 I got the following build error: In file included from ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:742: ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp: In member function 'virtual WTF::PassOwnPtr<WebKit::DrawingAreaProxy> QWKPagePrivate::createDrawingAreaProxy()': ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:126: error: control reaches end of non-void function
Balazs Kelemen
Comment 8 2011-01-11 07:33:45 PST
Created attachment 78528 [details] patch with qt parts Updated patch to TOT with real (non-stub) implementation of qt part.
WebKit Review Bot
Comment 9 2011-01-11 07:35:10 PST
Attachment 78528 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/AP..." exit_code: 1 WebKit2/UIProcess/API/mac/WKViewInternal.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 10 2011-01-11 07:47:52 PST
Comment on attachment 78528 [details] patch with qt parts You should get the QGraphicsWKView* via QWKPagePrivate::item instead.
Andreas Kling
Comment 11 2011-01-11 08:01:22 PST
(In reply to comment #10) > (From update of attachment 78528 [details]) > You should get the QGraphicsWKView* via QWKPagePrivate::item instead. Ehm. I just learned that the variable I'm referring to has not hit trunk yet (branches.. grmbl..) We don't want to tie the QWKPage and QGraphicsWKView together like that on the API level though. I'd rather we add a QGraphicsItem* member to QWKPagePrivate and stash the QGraphicsWKView* in there during QWKPagePrivate::init().
Balazs Kelemen
Comment 12 2011-01-11 08:38:16 PST
Created attachment 78533 [details] Patch
WebKit Review Bot
Comment 13 2011-01-11 08:39:45 PST
Attachment 78533 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/AP..." exit_code: 1 WebKit2/UIProcess/API/mac/WKViewInternal.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 14 2011-01-11 08:48:40 PST
Comment on attachment 78533 [details] Patch Better, thanks. r=me
Balazs Kelemen
Comment 15 2011-01-11 09:22:35 PST
Comment on attachment 78533 [details] Patch Clearing flags on attachment: 78533 Committed r75506: <http://trac.webkit.org/changeset/75506>
Balazs Kelemen
Comment 16 2011-01-11 09:22:46 PST
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 17 2011-01-11 09:26:14 PST
*** Bug 52183 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.