Bug 51360

Summary: [chromium] Media player styles being overridden
Product: WebKit Reporter: Steve Lacey <sjl>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Steve Lacey
Reported 2010-12-20 15:56:26 PST
media/controls-styling.html is failing for chromium due to missing base styles in mediaControlsChromium.css. Fix is underway.
Attachments
Patch (2.39 KB, patch)
2010-12-20 16:37 PST, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2010-12-20 16:55 PST, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Lacey
Comment 1 2010-12-20 16:37:58 PST
Created attachment 77053 [details] Patch
WebKit Review Bot
Comment 2 2010-12-20 16:42:03 PST
Attachment 77053 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/css/mediaControlsChromium.css']" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Levin
Comment 3 2010-12-20 16:50:50 PST
Comment on attachment 77053 [details] Patch Tabs in changelog (and this needs to be perfect to go through the commit queue).
Steve Lacey
Comment 4 2010-12-20 16:55:24 PST
Created attachment 77056 [details] Patch
WebKit Commit Bot
Comment 5 2010-12-20 18:25:04 PST
Comment on attachment 77056 [details] Patch Clearing flags on attachment: 77056 Committed r74381: <http://trac.webkit.org/changeset/74381>
WebKit Commit Bot
Comment 6 2010-12-20 18:25:11 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2010-12-20 19:21:54 PST
The commit-queue encountered the following flaky tests while processing attachment 77056 [details]: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.