Bug 51200

Summary: [Web Timing] Navigation type enums should begin with TYPE_
Product: WebKit Reporter: James Simonsen <simonjam>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, fishd, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://www.w3.org/TR/navigation-timing/
Bug Depends on:    
Bug Blocks: 30685, 48922    
Attachments:
Description Flags
Patch none

James Simonsen
Reported 2010-12-16 11:09:39 PST
According to the spec, the Navigation Type enums should all begin with TYPE_. Ours don't.
Attachments
Patch (6.82 KB, patch)
2010-12-16 15:39 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2010-12-16 15:36:04 PST
Also, TYPE_RESERVED is missing.
James Simonsen
Comment 2 2010-12-16 15:39:52 PST
Created attachment 76821 [details] Patch
Tony Gentilcore
Comment 3 2010-12-16 17:15:39 PST
LGTM I have a weak preference that we get don't add TYPE_RESERVED. I just don't think it provides any real value. But it may or may not be worth changing the spec at this point and we should pass the compliance tests.
James Simonsen
Comment 4 2010-12-16 17:21:28 PST
(In reply to comment #3) > LGTM > > I have a weak preference that we get don't add TYPE_RESERVED. I just don't think it provides any real value. But it may or may not be worth changing the spec at this point and we should pass the compliance tests. Agreed. They're really rushing to get this to last call and I don't think this is worth holding them up. Can I get an r+ from a reviewer?
WebKit Commit Bot
Comment 5 2010-12-17 02:02:37 PST
The commit-queue encountered the following flaky tests while processing attachment 76821 [details]: inspector/styles-new-API.html bug 50889 (authors: apavlov@chromium.org and pfeldman@chromium.org) http/tests/inspector/extensions-headers.html bug 51239 (author: caseq@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2010-12-17 02:20:04 PST
Comment on attachment 76821 [details] Patch Clearing flags on attachment: 76821 Committed r74241: <http://trac.webkit.org/changeset/74241>
WebKit Commit Bot
Comment 7 2010-12-17 02:20:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.