Bug 51089

Summary: text-combine value name changed
Product: WebKit Reporter: Takumi Takano <takano>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, commit-queue, hyatt, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48538    
Attachments:
Description Flags
Proposed patch.
mitz: review-
New proposed patch. none

Takumi Takano
Reported 2010-12-14 20:17:37 PST
text-combine's value names were changed from "none|cluster|upright" to "none|horizontal" in the latest css3 proposal.
Attachments
Proposed patch. (5.72 KB, patch)
2010-12-14 20:40 PST, Takumi Takano 		mitz: review-
DetailsFormatted DiffDiff
New proposed patch. (6.54 KB, patch)
2010-12-14 21:26 PST, Takumi Takano 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Takumi Takano
Comment 1 2010-12-14 20:40:49 PST
Created attachment 76623 [details] Proposed patch.
mitz
Comment 2 2010-12-14 20:50:28 PST
Comment on attachment 76623 [details] Proposed patch. Good, but you should also update the size of the bit field in StyleRareNomInheritedData.
Takumi Takano
Comment 3 2010-12-14 21:26:56 PST
Created attachment 76629 [details] New proposed patch. Changed textCombine field size in StyleRareNonInheritedData.h.
WebKit Commit Bot
Comment 4 2010-12-14 22:47:08 PST
The commit-queue encountered the following flaky tests while processing attachment 76629 [details]: inspector/styles-source-offsets.html bug 51095 (authors: apavlov@chromium.org and pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2010-12-14 22:49:01 PST
Comment on attachment 76629 [details] New proposed patch. Clearing flags on attachment: 76629 Committed r74098: <http://trac.webkit.org/changeset/74098>
WebKit Commit Bot
Comment 6 2010-12-14 22:49:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.