Bug 50707

Summary: [Qt] Build fix for Symbian after recent allocator refactoring
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: JavaScriptCoreAssignee: Siddharth Mathur <s.mathur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, laszlo.gombos, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
exclude Symbian from trying to compile POSIX memory management code
none
no POSIXy love for Symbian
none
updated patch with Changelog corrected.
none
Correct syntax and correct changelog none

Siddharth Mathur
Reported 2010-12-08 12:46:17 PST
wtf.pri should unix!symbian to avoid POSIX memory management code from being compile for Symbian.
Attachments
exclude Symbian from trying to compile POSIX memory management code (453 bytes, patch)
2010-12-08 12:51 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
no POSIXy love for Symbian (990 bytes, patch)
2010-12-08 13:17 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
updated patch with Changelog corrected. (1022 bytes, patch)
2010-12-10 07:26 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Correct syntax and correct changelog (1023 bytes, patch)
2010-12-10 07:32 PST, Siddharth Mathur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Siddharth Mathur
Comment 1 2010-12-08 12:51:04 PST
Created attachment 75948 [details] exclude Symbian from trying to compile POSIX memory management code
Siddharth Mathur
Comment 2 2010-12-08 13:17:58 PST
Created attachment 75954 [details] no POSIXy love for Symbian
Laszlo Gombos
Comment 3 2010-12-09 08:37:52 PST
Comment on attachment 75954 [details] no POSIXy love for Symbian View in context: https://bugs.webkit.org/attachment.cgi?id=75954&action=review > JavaScriptCore/ChangeLog:5 > + Build fix for Symbian: don't compile POSIX memory management implementation We usually have a [Qt] prefix in the title for Qt-only changes. > JavaScriptCore/wtf/wtf.pri:46 > +unix!symbian: SOURCES += wtf/OSAllocatorPosix.cpp Don't we need a ":" to make it "unix:!symbian" ?
Siddharth Mathur
Comment 4 2010-12-09 08:45:40 PST
The existing syntax in the patch works OK, for example the following snippet prints "Hello Symbian" only without any warnings. I will fix the Changelog entry in a new patch. ## test.pro ## unix!symbian:message("Hello Unix") symbian:message("Hello Symbian")
Siddharth Mathur
Comment 5 2010-12-10 07:26:47 PST
Created attachment 76194 [details] updated patch with Changelog corrected.
Siddharth Mathur
Comment 6 2010-12-10 07:32:23 PST
Created attachment 76196 [details] Correct syntax and correct changelog (I need more sleep and/or coffee)
Eric Seidel (no email)
Comment 7 2010-12-10 20:58:51 PST
Comment on attachment 76196 [details] Correct syntax and correct changelog Looks sane to me.
WebKit Review Bot
Comment 8 2010-12-10 23:14:47 PST
Comment on attachment 76196 [details] Correct syntax and correct changelog Clearing flags on attachment: 76196 Committed r73842: <http://trac.webkit.org/changeset/73842>
WebKit Review Bot
Comment 9 2010-12-10 23:14:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.