Bug 49964

Summary:	[gtk] Tests failing due to rounding problems in colors inside pixman
Product:	WebKit	Reporter:	Alejandro G. Castro <alex>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, cgarcia, clopez, leandro, mrobinson, pnormand, rakuco, zan
Priority:	P2	Keywords:	Gtk, LayoutTestFailure
Version:	528+ (Nightly build)
Hardware:	PC
OS:	Linux

Alejandro G. Castro

Reported 2010-11-23 03:45:52 PST

We have to check if this is a problem in the gtk port, when rendering of getting the results. Skipping until that point.

Attachments
Add attachment proposed patch, testcase, etc.

Alejandro G. Castro

Comment 1 2010-12-07 02:40:18 PST

I've send an email explaining what's going on in this situations, we can wait for some feedback from cairo people and decide about it: http://lists.cairographics.org/archives/cairo/2010-December/021295.html

Martin Robinson

Comment 2 2010-12-20 23:02:36 PST

The tests this bug refers to may not be failing any longer, because of changes to the tests. In any case, we should list them here: canvas-scale-drawImage-shadow.html canvas-scale-fillRect-shadow.html canvas-scale-fillPath-shadow.html canvas-scale-strokePath-shadow.html

Carlos Garcia Campos

Comment 3 2011-01-26 03:32:43 PST

The tests failing for me in this moment that seem to be due to this bug are: fast/canvas/canvas-getImageData.html fast/canvas/canvas-fillPath-shadow.html fast/canvas/canvas-strokePath-shadow.html fast/canvas/canvas-scale-strokePath-shadow.html

Carlos Garcia Campos

Comment 4 2011-03-09 03:46:45 PST

*** Bug 55670 has been marked as a duplicate of this bug. ***

Raphael Kubo da Costa (:rakuco)

Comment 5 2011-10-03 11:29:31 PDT

Right now, only fast/canvas/canvas-fillPath-shadow.html and fast/canvas/canvas-strokePath-shadow.html fail here.

Martin Robinson

Comment 6 2011-10-03 11:51:58 PDT

(In reply to comment #5) > Right now, only fast/canvas/canvas-fillPath-shadow.html and fast/canvas/canvas-strokePath-shadow.html fail here. It may vary depending on your processor and Cairo version. :/ This is an annoying issue because it seems like the only way we can know if this is fixed or not is to unskip the tests.

Zan Dobersek

Comment 7 2012-05-05 09:52:32 PDT

The following tests were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt: fast/canvas/canvas-getImageData.html fast/canvas/canvas-scale-strokePath-shadow.html fast/canvas/canvas-strokePath-shadow.html fast/canvas/canvas-transforms-fillRect-shadow.html fast/canvas/rgba-parsing.html Their expectations were removed in r116122[1] (covered by bug #85591). Tests that are covered by this bug and are still failing are the following: fast/canvas/canvas-fillPath-shadow.html 1: http://trac.webkit.org/changeset/116122

Carlos Alberto Lopez Perez

Comment 8 2015-07-08 10:45:20 PDT

The test fast/canvas/canvas-fillPath-shadow.html pass now after the upgrade of GTK+, Cairo, Gdk-Pixbuf and GLib done in r186500 <http://trac.webkit.org/r186500>. I have updated the expectations file on http://trac.webkit.org/changeset/186513 Should we close this bug as fixed?

Martin Robinson

Comment 9 2015-07-08 10:47:28 PDT

(In reply to comment #8) > The test fast/canvas/canvas-fillPath-shadow.html pass now after the upgrade > of GTK+, Cairo, Gdk-Pixbuf and GLib done in r186500 > <http://trac.webkit.org/r186500>. > > I have updated the expectations file on > http://trac.webkit.org/changeset/186513 > > Should we close this bug as fixed? Yes, probably. If the problems reappear is unlikely that people will remember this bug.

Note You need to log in before you can comment on or make changes to this bug.