Bug 49490

Summary: [Qt] Path stroke lacks blur shadow support
Product: WebKit Reporter: Helder Correia <helder>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mdelaney7
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 34479    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Test for stroke gradient and fill, not path
none
Fix bug ID in changelog
none
Remove duplicate file content from the test none

Helder Correia
Reported 2010-11-13 00:25:51 PST
ctx.blurShadow is not working for paths in the Qt port, it results a solid shadow.
Attachments
Patch (8.63 KB, patch)
2010-11-13 00:29 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (8.42 KB, patch)
2010-11-14 00:32 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (8.47 KB, patch)
2010-11-19 16:47 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Test for stroke gradient and fill, not path (8.47 KB, patch)
2010-11-19 17:34 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Fix bug ID in changelog (12.71 KB, patch)
2010-11-19 21:32 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Remove duplicate file content from the test (8.47 KB, patch)
2010-11-20 19:38 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2010-11-13 00:29:48 PST
Created attachment 73811 [details] Patch
Helder Correia
Comment 2 2010-11-14 00:32:03 PST
Created attachment 73843 [details] Patch
Helder Correia
Comment 3 2010-11-19 16:47:24 PST
Created attachment 74441 [details] Patch
Helder Correia
Comment 4 2010-11-19 17:34:29 PST
Created attachment 74450 [details] Test for stroke gradient and fill, not path
Helder Correia
Comment 5 2010-11-19 17:36:24 PST
(In reply to comment #4) > Created an attachment (id=74450) [details] > Test for stroke gradient and fill, not path What I meant was "stroke gradient and pattern, not fill gradient and pattern".
Andreas Kling
Comment 6 2010-11-19 20:55:41 PST
Comment on attachment 74450 [details] Test for stroke gradient and fill, not path View in context: https://bugs.webkit.org/attachment.cgi?id=74450&action=review Patch looks good, except one thing: > LayoutTests/ChangeLog:6 > + [Qt] Path fill lacks blur shadow support > + https://bugs.webkit.org/show_bug.cgi?id=49491 This refers to the wrong bug.
Helder Correia
Comment 7 2010-11-19 21:32:08 PST
Created attachment 74466 [details] Fix bug ID in changelog
Andreas Kling
Comment 8 2010-11-19 21:33:27 PST
Comment on attachment 74466 [details] Fix bug ID in changelog r=me
WebKit Commit Bot
Comment 9 2010-11-20 01:28:53 PST
The commit-queue encountered the following flaky tests while processing attachment 74466 [details]: fast/canvas/canvas-strokePath-shadow.html compositing/iframes/overlapped-nested-iframes.html Please file bugs against the tests. These tests were authored by simon.fraser@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2010-11-20 01:54:13 PST
Comment on attachment 74466 [details] Fix bug ID in changelog Rejecting patch 74466 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ....................... fast/body-propagation/overflow ................... fast/borders ............................................................. fast/box-shadow ..... fast/box-sizing .... fast/canvas ......................................................... fast/canvas/canvas-strokePath-shadow.html -> failed Exiting early after 1 failures. 6085 tests run. 139.28s total testing time 6084 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 3 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/6260053
Helder Correia
Comment 11 2010-11-20 19:38:00 PST
Created attachment 74493 [details] Remove duplicate file content from the test
Andreas Kling
Comment 12 2010-11-20 19:41:52 PST
Comment on attachment 74493 [details] Remove duplicate file content from the test D'oh! :)
WebKit Commit Bot
Comment 13 2010-11-20 20:20:06 PST
Comment on attachment 74493 [details] Remove duplicate file content from the test Clearing flags on attachment: 74493 Committed r72490: <http://trac.webkit.org/changeset/72490>
WebKit Commit Bot
Comment 14 2010-11-20 20:20:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.