Bug 47961

Summary: Get old-run-webkit-tests mostly working with Win32 Perl
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, sfalken
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48166    
Attachments:
Description Flags
Patch ddkilzer: review+, ddkilzer: commit-queue-

Adam Roben (:aroben)
Reported 2010-10-19 18:07:39 PDT
Get old-run-webkit-tests mostly working with Win32 Perl
Attachments
Patch (19.69 KB, patch)
2010-10-19 18:10 PDT, Adam Roben (:aroben) 		ddkilzer: review+
ddkilzer: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-10-19 18:10:36 PDT
Created attachment 71237 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2010-10-19 21:05:01 PDT
Comment on attachment 71237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71237&action=review r=me > WebKitTools/Scripts/old-run-webkit-tests:417 > + $dumpToolName .= ".exe"; Optional: I think there is a Perl-ish way to get the executable extension via built-in variable or via the Config module ($Config{_exe}). > WebKitTools/Scripts/old-run-webkit-tests:1331 > + unshift @{$args}, "perl", $execScript; It would be a good idea to extract all of these "perl" strings into a global variable. It will make it easier to replace them or update them later. > WebKitTools/Scripts/webkitdirs.pm:1082 > + print $vcBuildPath, "\n"; Debug print statement?
Adam Roben (:aroben)
Comment 3 2010-10-20 15:25:14 PDT
Comment on attachment 71237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71237&action=review >> WebKitTools/Scripts/old-run-webkit-tests:417 >> + $dumpToolName .= ".exe"; > > Optional: I think there is a Perl-ish way to get the executable extension via built-in variable or via the Config module ($Config{_exe}). OK, I'll use $Config{_exe}. I couldn't find a built-in variable that would give us the string. >> WebKitTools/Scripts/old-run-webkit-tests:1331 >> + unshift @{$args}, "perl", $execScript; > > It would be a good idea to extract all of these "perl" strings into a global variable. It will make it easier to replace them or update them later. Sounds good. I'll use a $perlInterpreter global variable. >> WebKitTools/Scripts/webkitdirs.pm:1082 >> + print $vcBuildPath, "\n"; > > Debug print statement? Indeed! Good catch. Removed.
Adam Roben (:aroben)
Comment 4 2010-10-20 16:14:24 PDT
Committed r70188: <http://trac.webkit.org/changeset/70188>
Note You need to log in before you can comment on or make changes to this bug.