Bug 47775
Summary: | Web Inspector: notify messages should belong to the domain and dispatch against non-WebInspector instance. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> |
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 50337, 50626, 50690, 50906 | ||
Bug Blocks: |
Pavel Feldman
These:
[notify] void characterDataModified(out long id, out String newValue);
[notify] void childNodeCountUpdated(out long id, out int newValue);
[notify] void childNodeInserted(out long parentId, out long prevId, out Object node);
[notify] void childNodeRemoved(out long parentId, out long id);
should be:
[handler=DOM, notify], or better [domain=DOM, notify]
and get dispatched against WebInspector.domAgent instance instead of WebInspector instance.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Pavel Feldman
All parts resolved, closing met bug.