Bug 47584

Summary: Add wtf/text/StringConcatenate
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: Web Template FrameworkAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 18994    
Attachments:
Description Flags
Patch
none
Patch v2 krit: review+

Nikolas Zimmermann
Reported 2010-10-13 03:19:12 PDT
Move JSC/runtime/StringConcatenate to wtf/text, make it work for Strings too. Add a special JSC/runtime/UStringConcatenate class that inherits from StringConcatenate, and extends it for UString. Exactly the same design that has been done while refactoring StringBuilder. The UString variants can all be removed as soon as WTF::String & JSC::UString converge.
Attachments
Patch (55.82 KB, patch)
2010-10-13 03:28 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (71.37 KB, patch)
2010-10-13 03:39 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-10-13 03:28:11 PDT
Created attachment 70594 [details] Patch Please wait for EWS before reviewing.
Nikolas Zimmermann
Comment 2 2010-10-13 03:39:11 PDT
Created attachment 70596 [details] Patch v2 I ran svn-create-patch from within JSC, maybe that's why the bots can't apply the patch?
Dirk Schulze
Comment 3 2010-10-13 07:19:26 PDT
Comment on attachment 70596 [details] Patch v2 LGTM. r=me
Nikolas Zimmermann
Comment 4 2010-10-13 07:51:16 PDT
Landed in r69663.
Note You need to log in before you can comment on or make changes to this bug.