Bug 43075

Summary: Pick up spec change w.r.t. figcaption and summary
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-07-27 13:42:44 PDT
Pick up spec change w.r.t. figcaption and summary
Attachments
Patch (3.49 KB, patch)
2010-07-27 13:43 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-27 13:43:35 PDT
Created attachment 62738 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-27 13:46:06 PDT
Comment on attachment 62738 [details] Patch LGTM. Thanks.
WebKit Commit Bot
Comment 3 2010-07-28 16:03:01 PDT
Comment on attachment 62738 [details] Patch Rejecting patch 62738 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Last 500 characters of output: tch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/html5lib/runner-expected-html5.txt Hunk #1 FAILED at 162. Hunk #2 FAILED at 183. 2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected-html5.txt.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/HTMLTreeBuilder.cpp Hunk #1 succeeded at 1938 (offset -22 lines). Hunk #2 succeeded at 1949 (offset -22 lines). Full output: http://queues.webkit.org/results/3638061
Adam Barth
Comment 4 2010-08-04 17:36:46 PDT
Comment on attachment 62738 [details] Patch Clearing flags on attachment: 62738 Committed r64699: <http://trac.webkit.org/changeset/64699>
Adam Barth
Comment 5 2010-08-04 17:36:52 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 6 2010-08-05 00:02:14 PDT
I would really appreciate a more detailed ChangeLog - there is no easy way to find out what changed here!
Adam Barth
Comment 7 2010-08-05 00:05:53 PDT
> I would really appreciate a more detailed ChangeLog - there is no easy way to find out what changed here! The diff to the spec is essentially identical to the diff to the code. These tags got added to these lists. I'm not really sure why, but I assume the working group knows what it's doing.
Note You need to log in before you can comment on or make changes to this bug.