Bug 42794

Summary: Let's pass the doctype01.dat tests again, please
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gsnedders
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2010-07-21 16:15:52 PDT
Let's pass the doctype01.dat tests again, please
Attachments
Patch (13.97 KB, patch)
2010-07-21 16:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-07-21 16:18:31 PDT
Created attachment 62244 [details] Patch
Eric Seidel (no email)
Comment 2 2010-07-21 16:20:35 PDT
Comment on attachment 62244 [details] Patch Isn't our dom2string.js directly from upstream? Does the upstream version have this bug?
Adam Barth
Comment 3 2010-07-21 16:54:51 PDT
Yeah, I've been discussing that with gsnedders in #whatwg. There isn't a more awesome version anywhere. I think he might grab this diff and apply it upstream. He also mentioned wanting to rev the whole runner.html.
Sam Sneddon [:gsnedders]
Comment 4 2010-07-21 17:00:10 PDT
Eric: which upstream version? As far as I know the upstream versions of it are just what myself and Simon have up on html5.org, which are in varying states of out-of-dateness. Both have this bug. I was intending on updating the copy I have to fix a number of issues in the runner soon, I'll try and include the fix for this in it. However, the patch is wrong; it should be: if (current.publicId !== null || current.systemId !== null)
Adam Barth
Comment 5 2010-07-21 17:08:45 PDT
Will fix before landing.
Adam Barth
Comment 6 2010-07-21 18:06:54 PDT
Hum... That doesn't actually work. I think that's because of we're bad at handling NULL public and system identifiers. I'll change it in a future patch.
Adam Barth
Comment 7 2010-07-21 18:08:43 PDT
Comment on attachment 62244 [details] Patch Clearing flags on attachment: 62244 Committed r63871: <http://trac.webkit.org/changeset/63871>
Adam Barth
Comment 8 2010-07-21 18:08:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.