Bug 42512

Summary: [Web Timing] Move times to DocumentLoader and fix bugs in mark points
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30685    
Attachments:
Description Flags
Patch fishd: review+

Tony Gentilcore
Reported 2010-07-17 21:46:08 PDT
[Web Timing] Move times to DocumentLoader and fix bugs in mark points
Attachments
Patch (30.14 KB, patch)
2010-07-18 12:14 PDT, Tony Gentilcore 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-07-18 12:14:00 PDT
Created attachment 61906 [details] Patch
Tony Gentilcore
Comment 2 2010-07-18 12:25:25 PDT
I believe this fixes the last of the critical web timing bugs. Sorry for the big patch, but maybe its actually good to review all of the marks in one place.
Darin Fisher (:fishd, Google)
Comment 3 2010-07-19 13:50:20 PDT
Comment on attachment 61906 [details] Patch WebCore/loader/DocumentLoader.h:208 + DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; } one minor suggestion: you could probably get away with shortening this member function to "timing()" as the "documentLoad" prefix is sort of redundant with the name of the class, DocumentLoader. R=me
Tony Gentilcore
Comment 4 2010-07-19 14:18:00 PDT
(In reply to comment #3) > (From update of attachment 61906 [details]) > WebCore/loader/DocumentLoader.h:208 > + DocumentLoadTiming* documentLoadTiming() { return &m_documentLoadTiming; } > one minor suggestion: you could probably get away with shortening this member > function to "timing()" as the "documentLoad" prefix is sort of redundant with the > name of the class, DocumentLoader. Thanks! Fixed and landing. > > R=me
Tony Gentilcore
Comment 5 2010-07-19 14:56:11 PDT
Committed r63689: <http://trac.webkit.org/changeset/63689>
Note You need to log in before you can comment on or make changes to this bug.