Bug 41564

Summary: Implement performance.navigation.type
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30685    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Tony Gentilcore
Reported 2010-07-02 22:30:14 PDT
Implement performance.navigation.type
Attachments
Patch (8.89 KB, patch)
2010-07-02 22:34 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.87 KB, patch)
2010-07-07 10:34 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.87 KB, patch)
2010-07-08 08:58 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-07-02 22:34:43 PDT
Created attachment 60440 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-07-03 07:42:41 PDT
Comment on attachment 60440 [details] Patch WebCore/page/Navigation.h:56 + NAVIGATE = 0, Enum convention is CamelCase. Other than that, the baby's starting to take its first steps!
Tony Gentilcore
Comment 3 2010-07-07 10:34:05 PDT
Created attachment 60751 [details] Patch for landing
WebKit Commit Bot
Comment 4 2010-07-07 23:46:51 PDT
Comment on attachment 60751 [details] Patch for landing Rejecting patch 60751 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 19306 test cases. fast/dom/navigation-type-back-forward.html -> failed Exiting early after 1 failures. 6430 tests run. 103.81s total testing time 6429 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://webkit-commit-queue.appspot.com/results/3480011
Tony Gentilcore
Comment 5 2010-07-08 08:58:47 PDT
Created attachment 60894 [details] Patch for landing
WebKit Commit Bot
Comment 6 2010-07-09 06:58:43 PDT
Comment on attachment 60894 [details] Patch for landing Clearing flags on attachment: 60894 Committed r62947: <http://trac.webkit.org/changeset/62947>
WebKit Commit Bot
Comment 7 2010-07-09 06:58:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.