Bug 41225

Summary: Tree builder doesn't need to return a Node
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41123    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2010-06-25 13:53:18 PDT
Tree builder doesn't need to return a Node
Attachments
Patch (16.03 KB, patch)
2010-06-25 13:54 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.05 KB, patch)
2010-06-25 14:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-25 13:54:43 PDT
Created attachment 59793 [details] Patch
Darin Adler
Comment 2 2010-06-25 13:55:55 PDT
Comment on attachment 59793 [details] Patch > - // Implementation coming in the next patch. > - return 0; Should there be an ASSERT_NOT_REACHED here?
Adam Barth
Comment 3 2010-06-25 13:58:35 PDT
> Should there be an ASSERT_NOT_REACHED here? Eventually there should be. We'll hit that case until we implement all the states though.
Adam Barth
Comment 4 2010-06-25 13:59:09 PDT
Comment on attachment 59793 [details] Patch Thanks for the review. :)
Adam Barth
Comment 5 2010-06-25 14:03:10 PDT
Created attachment 59794 [details] Patch for landing
Adam Barth
Comment 6 2010-06-25 16:32:22 PDT
Comment on attachment 59794 [details] Patch for landing Clearing flags on attachment: 59794 Committed r61914: <http://trac.webkit.org/changeset/61914>
Adam Barth
Comment 7 2010-06-25 16:32:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.