Bug 39525

Summary: Make HTML5 parser parse <script>alert("<hi>");</script>
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259, 39533    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2010-05-21 19:22:22 PDT
Make HTML5 parser parse <script>alert("<hi>");</script>
Attachments
Patch (12.16 KB, patch)
2010-05-21 19:28 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (15.44 KB, patch)
2010-05-22 01:13 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (15.96 KB, patch)
2010-05-22 08:39 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.97 KB, patch)
2010-05-23 13:20 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-21 19:28:06 PDT
Created attachment 56772 [details] Patch
Adam Barth
Comment 2 2010-05-22 01:13:07 PDT
Created attachment 56775 [details] Patch
Adam Barth
Comment 3 2010-05-22 01:26:59 PDT
Comment on attachment 56775 [details] Patch I'm not really happy with this patch yet.
Adam Barth
Comment 4 2010-05-22 08:39:01 PDT
Created attachment 56779 [details] Patch
Eric Seidel (no email)
Comment 5 2010-05-23 13:12:16 PDT
Comment on attachment 56779 [details] Patch WebCore/html/HTML5Lexer.cpp:225 + m_bufferedEndTagName.clear(); This seems like a temporary hack we should remove. WebCore/html/HTML5Lexer.cpp:331 + emitCurrentToken(); Seems strange that we don't return right after this call. Do we have asserts in emitCurrentToken that we haven't already emitted? WebCore/html/HTML5Lexer.cpp:1264 + if (actual[i] != appropriate[i]) Doesn't a UChar buffer compare method exist already? Or shouldn't we make this into one? WebCore/html/HTML5Token.h:128 + m_cachedName = AtomicString(StringImpl::adopt(m_data)); This is a good change. :) Please conisder above comments. This seems less than perfect but moves us forward. 100% correctness first, then several rounds of bathing are needed. :)
Adam Barth
Comment 6 2010-05-23 13:20:43 PDT
Created attachment 56827 [details] Patch for landing
WebKit Commit Bot
Comment 7 2010-05-23 13:38:16 PDT
Comment on attachment 56827 [details] Patch for landing Clearing flags on attachment: 56827 Committed r60047: <http://trac.webkit.org/changeset/60047>
WebKit Commit Bot
Comment 8 2010-05-23 13:38:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.