Bug 39333

Summary: Add more state to the HTML5 lexer
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Work in progress
none
work in progress
none
Patch eric: review+

Adam Barth
Reported 2010-05-18 17:04:25 PDT
Add more state to the HTML5 lexer
Attachments
Work in progress (7.09 KB, patch)
2010-05-18 17:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
work in progress (6.86 KB, patch)
2010-05-18 17:10 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (6.84 KB, patch)
2010-05-18 17:25 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-05-18 17:05:21 PDT
Created attachment 56424 [details] Work in progress
Adam Barth
Comment 2 2010-05-18 17:10:11 PDT
Created attachment 56427 [details] work in progress
Adam Barth
Comment 3 2010-05-18 17:25:53 PDT
Created attachment 56432 [details] Patch
WebKit Review Bot
Comment 4 2010-05-18 17:27:50 PDT
Attachment 56432 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5Lexer.cpp:703: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebCore/html/HTML5Lexer.cpp:725: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 5 2010-05-18 17:32:06 PDT
Committed r59721: <http://trac.webkit.org/changeset/59721>
David Levin
Comment 6 2010-05-19 16:44:08 PDT
This is committed and resolved. Should the r? be removed (so it gets of out the review queue)?
Note You need to log in before you can comment on or make changes to this bug.