Bug 37324

Summary: [Qt] tst_QWebPage::createPlugin() fails
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: Tools / TestsAssignee: Robert Hogan <robert>
Status: CLOSED FIXED    
Severity: Blocker CC: kling, robert
Priority: P1 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Patch none

Simon Hausmann
Reported 2010-04-09 03:03:15 PDT
Reproducible on Linux/X11: FAIL! : tst_QWebPage::createPlugin() Compared values are not the same Actual (newPage->calls.count()): 1 Expected (0): 0 Loc: [/home/shausman/src/webkit/trunk/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(531)]
Attachments
Patch (9.37 KB, patch)
2010-04-20 14:19 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-04-09 03:54:26 PDT
This regression is caused by https://bugs.webkit.org/show_bug.cgi?id=32196
Simon Hausmann
Comment 2 2010-04-19 18:36:28 PDT
Robert, any ideas? :)
Robert Hogan
Comment 3 2010-04-20 11:59:43 PDT
(In reply to comment #2) > Robert, any ideas? :) Guilty as charged. The test is now invalid: // plugins not enabled by default, so the plugin shouldn't be loaded m_view->setHtml(QString("<html><body><object type='application/x-qt-plugin' classid='pushbutton' id='mybutton'/></body></html>")); QTRY_COMPARE(loadSpy.count(), 1); QCOMPARE(newPage->calls.count(), 0); m_view->settings()->setAttribute(QWebSettings::PluginsEnabled, true); OK to remove it presumably.
Robert Hogan
Comment 4 2010-04-20 14:19:49 PDT
Created attachment 53879 [details] Patch Updated Docs too..
Robert Hogan
Comment 5 2010-04-25 00:24:06 PDT
Landed as r58112
Simon Hausmann
Comment 6 2010-04-26 03:13:09 PDT
<cherry-pick-for-backport: r58112>
Simon Hausmann
Comment 7 2010-04-26 03:15:30 PDT
Revision r58112 cherry-picked into qtwebkit-2.0 with commit 87a4fa8d64160f9c7fc6b7600c22f58ac81002b9
Note You need to log in before you can comment on or make changes to this bug.